Fix JNI Local Reference reporting issue #18379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (isHeapObject(slotValue) && !_heap->objectIsInGap(slotValue)) { | ||
| doSlot(slotPtr, J9GC_ROOT_TYPE_STACK_SLOT, -1, (J9Object *)walkState); | ||
| if (J9_STACKWALK_SLOT_TYPE_JNI_LOCAL == ((J9StackWalkState *)walkState)->slotType) { | ||
| doSlot(slotPtr, J9GC_ROOT_TYPE_JNI_LOCAL, -1, (J9Object *)walkState);; |
LinHu2016
force-pushed
the
Loom_GC_update_21
branch
from
f9a9ad6 to
01b128f
Compare
dmitripivkine
approved these changes
Oct 31, 2023
|
jenkins test sanity win,aix jdk21 |
amicic
approved these changes
Oct 31, 2023
JNI Local References could be found on the stack(first 8 of them) or from GC_VMThreadJNISlotIterator (vmThread->jniLocalReferences). need to update MM_ReferenceChainWalker::doVMThreadSlot() to report J9GC_ROOT_TYPE_JNI_LOCAL type for the case walkState->slotType = J9_STACKWALK_SLOT_TYPE_JNI_LOCAL. Signed-off-by: hulin <[email protected]>
LinHu2016
force-pushed
the
Loom_GC_update_21
branch
from
01b128f to
479e4f7
Compare
|
changes rebased, so here is the link to jenkins builds https://openj9-jenkins.osuosl.org/view/Pull%20Requests/job/PullRequest-OpenJ9/4655/ |
|
one AIX subtest failed, but seems unrelated: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JNI Local References could be found on the stack(first 8 of them) or from GC_VMThreadJNISlotIterator (vmThread->jniLocalReferences). need to update MM_ReferenceChainWalker::doVMThreadSlot() to report J9GC_ROOT_TYPE_JNI_LOCAL type for the case walkState->slotType = J9_STACKWALK_SLOT_TYPE_JNI_LOCAL.
relate: #18378 and #17712
Signed-off-by: hulin [email protected]