Add helper functions for off heap technology changes #18303

VermaSh · 2023-10-18T19:57:33Z

Add helper functions to generate IL for array access and queries to check if off heap allocation is enabled. This includes minimum set of off heap changes needed to unblock #17969.

depends on eclipse-omr/omr#7150

VermaSh · 2023-11-03T14:37:25Z

@dmitripivkine @amicic @0xdaryl @zl-wang @vijaysun-omr Can I please get a review for this PR

vijaysun-omr · 2023-11-04T10:01:58Z

runtime/compiler/optimizer/J9TransformUtil.cpp

+   {
+   TR_ASSERT_FATAL_WITH_NODE(arrayObject,
+      TR::Compiler->om.isOffHeapAllocationEnabled(),
+      "This helpler shouldn't be called if off heap allocation is disabled.\n");


Typo "helpler"

vijaysun-omr · 2023-11-04T10:04:48Z

runtime/compiler/optimizer/J9TransformUtil.hpp

+    *    The compilation object
+    *
+    * \param arrayNode
+    *    The aray object node


Typo "aray"

vijaysun-omr · 2023-11-04T10:09:00Z

runtime/compiler/optimizer/J9TransformUtil.hpp

+    *
+    * \param elementSize
+    *    Array element size
+    *


Can we clarify what the strideNode means here ? It seems clearer how to use elementSize with indexNode to come up with an "offset tree" but what role a strideNode plays is less clear because it is not as clearly defined. Maybe an example/pseudocode would help.

I have updated the comment and variable name. Does it help or should I add more?

dmitripivkine

GC part of the change looks good, this is exact replica of off-heap prototype

VermaSh · 2023-11-07T18:46:55Z

Here's my build to verify that this PR doesn't cause any failures

vijaysun-omr · 2023-11-10T21:13:52Z

runtime/compiler/optimizer/J9TransformUtil.cpp

+   if (TR::Compiler->om.isOffHeapAllocationEnabled())
+      {
+      arrayAddressNode = generateDataAddrLoadTrees(comp, arrayNode);
+      if (offsetNode)


Does this node also need to be tagged as an internal pointer ?

Offset node doesn't contain an address; just an offset value relative to the array object pointer. So we should be ok not marking it as an internal pointer.

VermaSh · 2023-12-01T16:09:10Z

@vijaysun-omr can I get another set of review?

vijaysun-omr · 2023-12-01T23:04:13Z

Jenkins test sanity all jdk11

vijaysun-omr · 2023-12-04T15:54:50Z

@VermaSh please let me know when this is ready to be tested. Thanks

dsouzai · 2024-01-19T15:51:19Z

FYI you'll need to update the JITServer MINOR_NUMBER in CommunicationStream.hpp since there's a change in the vmInfo.

VermaSh · 2024-01-19T15:57:13Z

Launched an other personal build to verify changes

VermaSh · 2024-01-20T00:27:23Z

My personal build passed without any failures. @vijaysun-omr this is ready for review/merge.

OMR PR: eclipse-omr/omr#7150 must be merged before this. I'll remove the WIP tag once OMR PR is merged.

vijaysun-omr · 2024-01-23T23:48:14Z

The OMR PR is merged, but you may need it to get promoted first, before we can merge it. Please remove the WIP and comment when it is ready for review.

VermaSh · 2024-01-24T01:47:26Z

@vijaysun-omr This is ready for review. I'll post a comment here once my OMR changes are promoted.

VermaSh · 2024-01-25T04:02:52Z

@vijaysun-omr OMR changes were promoted. This should be safe to merge.

vijaysun-omr · 2024-01-25T13:00:51Z

Jenkins test sanity all jdk11

vijaysun-omr · 2024-01-25T20:48:54Z

Jenkins test sanity zlinux jdk11

VermaSh · 2024-01-25T21:00:46Z

Failure don't seem to be related to this PR. Probably just need to rebase.

Add definitions for j9gc_off_heap_allocation_enabled and J9::ObjectModel::isOffHeapAllocationEnabled() Source: eclipse-openj9#18163 Signed-off-by: midronij <[email protected]>

New APIs are: `generateDataAddrLoadTrees` `generateArrayAddressNode` `generateArrayStartTrees` `generateOffsetNode` Signed-off-by: Shubham Verma <[email protected]>

VermaSh · 2024-01-25T21:05:43Z

@vijaysun-omr Previous build failures should be gone now.

vijaysun-omr · 2024-01-25T22:23:00Z

Jenkins test sanity all jdk11

VermaSh · 2024-01-26T06:52:57Z

Build failures aren't related to this PR. They will be fixed in adoptium/TKG#492.

VermaSh marked this pull request as draft October 18, 2023 19:58

midronij mentioned this pull request Oct 19, 2023

Adjust arguments to Unsafe array operations while offheap is enabled #17969

Merged

dmitripivkine added comp:gc comp:jit labels Oct 20, 2023

VermaSh force-pushed the offHeapMemoryCommitAndDecommitFinal_base_changes branch 2 times, most recently from 36afdda to e22fa55 Compare November 3, 2023 04:05

VermaSh changed the title ~~WIP: Off heap technology changes~~ Off heap technology changes Nov 3, 2023

VermaSh marked this pull request as ready for review November 3, 2023 14:33

VermaSh force-pushed the offHeapMemoryCommitAndDecommitFinal_base_changes branch from e22fa55 to b2d8647 Compare November 3, 2023 14:35

VermaSh changed the title ~~Off heap technology changes~~ Helper functinos for off heap technology changes Nov 3, 2023

VermaSh force-pushed the offHeapMemoryCommitAndDecommitFinal_base_changes branch from b2d8647 to a36d342 Compare November 3, 2023 14:40

VermaSh changed the title ~~Helper functinos for off heap technology changes~~ Helper functions for off heap technology changes Nov 3, 2023

VermaSh changed the title ~~Helper functions for off heap technology changes~~ Add helper functions for off heap technology changes Nov 3, 2023

VermaSh mentioned this pull request Nov 3, 2023

Add contiguous array dataAddr field shadow symbol reference for off heap technology eclipse-omr/omr#7150

Merged

vijaysun-omr reviewed Nov 4, 2023

View reviewed changes

dmitripivkine approved these changes Nov 6, 2023

View reviewed changes

amicic approved these changes Nov 7, 2023

View reviewed changes

VermaSh force-pushed the offHeapMemoryCommitAndDecommitFinal_base_changes branch from a36d342 to 2bba7fc Compare November 7, 2023 18:31

vijaysun-omr reviewed Nov 10, 2023

View reviewed changes

vijaysun-omr approved these changes Dec 1, 2023

View reviewed changes

VermaSh changed the title ~~Add helper functions for off heap technology changes~~ WIP: Add helper functions for off heap technology changes Dec 4, 2023

VermaSh force-pushed the offHeapMemoryCommitAndDecommitFinal_base_changes branch from 2bba7fc to d9a0a6b Compare January 19, 2024 15:46

VermaSh requested a review from dsouzai as a code owner January 19, 2024 15:46

VermaSh force-pushed the offHeapMemoryCommitAndDecommitFinal_base_changes branch from d9a0a6b to 4fd4624 Compare January 19, 2024 15:53

VermaSh changed the title ~~WIP: Add helper functions for off heap technology changes~~ Add helper functions for off heap technology changes Jan 24, 2024

midronij and others added 2 commits January 25, 2024 16:03

Add API to query off heap allocation availability

f5dcc80

Add definitions for j9gc_off_heap_allocation_enabled and J9::ObjectModel::isOffHeapAllocationEnabled() Source: eclipse-openj9#18163 Signed-off-by: midronij <[email protected]>

Add APIs to help with array access

e766755

New APIs are: `generateDataAddrLoadTrees` `generateArrayAddressNode` `generateArrayStartTrees` `generateOffsetNode` Signed-off-by: Shubham Verma <[email protected]>

VermaSh force-pushed the offHeapMemoryCommitAndDecommitFinal_base_changes branch from 4fd4624 to e766755 Compare January 25, 2024 21:03

vijaysun-omr merged commit 8a7c85e into eclipse-openj9:master Jan 26, 2024
10 of 13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add helper functions for off heap technology changes #18303

Add helper functions for off heap technology changes #18303

VermaSh commented Oct 18, 2023 •

edited

Loading

VermaSh commented Nov 3, 2023

vijaysun-omr Nov 4, 2023

vijaysun-omr Nov 4, 2023

vijaysun-omr Nov 4, 2023 •

edited

Loading

VermaSh Nov 7, 2023

dmitripivkine left a comment

VermaSh commented Nov 7, 2023 •

edited

Loading

vijaysun-omr Nov 10, 2023

VermaSh Nov 20, 2023

VermaSh commented Dec 1, 2023

vijaysun-omr commented Dec 1, 2023

vijaysun-omr commented Dec 4, 2023

dsouzai commented Jan 19, 2024

VermaSh commented Jan 19, 2024

VermaSh commented Jan 20, 2024 •

edited

Loading

vijaysun-omr commented Jan 23, 2024

VermaSh commented Jan 24, 2024

VermaSh commented Jan 25, 2024

vijaysun-omr commented Jan 25, 2024

vijaysun-omr commented Jan 25, 2024

VermaSh commented Jan 25, 2024

VermaSh commented Jan 25, 2024

vijaysun-omr commented Jan 25, 2024

VermaSh commented Jan 26, 2024

Add helper functions for off heap technology changes #18303

Add helper functions for off heap technology changes #18303

Conversation

VermaSh commented Oct 18, 2023 • edited Loading

VermaSh commented Nov 3, 2023

vijaysun-omr Nov 4, 2023

Choose a reason for hiding this comment

vijaysun-omr Nov 4, 2023

Choose a reason for hiding this comment

vijaysun-omr Nov 4, 2023 • edited Loading

Choose a reason for hiding this comment

VermaSh Nov 7, 2023

Choose a reason for hiding this comment

dmitripivkine left a comment

Choose a reason for hiding this comment

VermaSh commented Nov 7, 2023 • edited Loading

vijaysun-omr Nov 10, 2023

Choose a reason for hiding this comment

VermaSh Nov 20, 2023

Choose a reason for hiding this comment

VermaSh commented Dec 1, 2023

vijaysun-omr commented Dec 1, 2023

vijaysun-omr commented Dec 4, 2023

dsouzai commented Jan 19, 2024

VermaSh commented Jan 19, 2024

VermaSh commented Jan 20, 2024 • edited Loading

vijaysun-omr commented Jan 23, 2024

VermaSh commented Jan 24, 2024

VermaSh commented Jan 25, 2024

vijaysun-omr commented Jan 25, 2024

vijaysun-omr commented Jan 25, 2024

VermaSh commented Jan 25, 2024

VermaSh commented Jan 25, 2024

vijaysun-omr commented Jan 25, 2024

VermaSh commented Jan 26, 2024

VermaSh commented Oct 18, 2023 •

edited

Loading

vijaysun-omr Nov 4, 2023 •

edited

Loading

VermaSh commented Nov 7, 2023 •

edited

Loading

VermaSh commented Jan 20, 2024 •

edited

Loading