-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests to verify JITServer with SSL #18262
Conversation
@mpirvu Can you please review? |
<command>bash $SCRIPPATH$ $TEST_RESROOT$ $TEST_JDK_BIN$ "$DEFAULT_JITSERVER_OPTIONS$" "$ENABLE_JITSERVER$ $JITSERVER_VERBOSE$ $JITSERVER_SSL1$" false</command> | ||
<output type="success" caseSensitive="no" regex="yes" javaUtilPattern="yes">(java|openjdk|semeru) version</output> | ||
<output type="required" caseSensitive="no" regex="no">JITServer Client Mode.</output> | ||
<output type="success" caseSensitive="no" regex="no">Successfully initialized SSL context</output> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember discussing that the test succeeds when any of the type="success"
criteria is met.
If that is the case, then "Successfully initialized SSL context" is sufficient to make the test pass, but in reality that is not enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this test we can make that condition type="required"
for "Successfully initialized SSL context" which will enforce the test to look for this condition and make the test pass only if the condition is met.
However the test will only search for the condition "Successfully initialized SSL context" in the output of the test which includes logs from the server and the client and the test will pass if either client or server logs contain the text.
I can remove the -Xjit:verbose={JITServer}
from the server side to avoid checking the logs from the server and change few conditions in the test which currently expects server side logs.
Or a better way might be to make the condition JITServer::StreamFailure: Failed to SSL_connect
as required
condition in the failure scenario and for success scenario make the Connected to a server
as required
condition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the server side verbose logging and modified the conditions to check if the connection was success/failure (based on the test criteria) as a required
condition.
c322704
to
d2f4407
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jenkins test sanity plinuxjit,xlinuxjit,zlinuxjit,alinux64jit jdk17 |
The ppc_le test failed with the error:
Seems due to #18184. The other failure is on x86_64 which fails with a timeout error while copying files:
|
jenkins test sanity xlinuxjit jdk17 |
Pls rebase to fix the compilation failure. |
d2f4407
to
7aeacc5
Compare
jenkins test sanity xlinuxjit jdk17 |
jenkins test sanity plinuxjit jdk17 |
The tests on ppcle (Hostname: |
@SajinaKandy Could you please fix the " Eclipse Foundation Contributor Agreement validation"? Maybe you have to revalidate again? |
Add tests to the existing jitserver tests under cmdLineTest for checking /verifying SSL connections with JITServer. This is part 2 for the work done in eclipse-openj9#17985 . Closes: #eclipse-openj9#17967 Signed-off-by: SajinaKandy <[email protected]>
7aeacc5
to
3663860
Compare
@mpirvu the eclipse eca validation is successful now. |
jenkins test sanity plinuxjit,xlinuxjit,zlinuxjit,alinux64jit jdk17 |
Fails again with the same error on ppc_le
|
Merging based on the comment here: #18262 (comment) |
Add tests to the existing
jitserver
tests undercmdLineTest
for checking/verifying SSL connections with JITServer. This is part 2 for the work done in #17985 .Closes: ##17967