(0.41) Update JVM_IsUseContainerSupport #18197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, in comparison to the RI, OpenJ9 shows a different output for
-XshowSettings:system outside a container because our
JVM_IsUseContainerSupport implementation differs from the RI.
This PR matches the latest RI behaviour for JVM_IsUseContainerSupport.
The RI returns TRUE from JVM_IsUseContainerSupport IFF
-XX:+UseContainerSupport is specified. This option is enabled by
default.
Currently, we return TRUE from JVM_IsUseContainerSupport if
-XX:+UseContainerSupport is specified && we are inside a container.
The return value of JVM_IsUseContainerSupport determines the output
of -XshowSettings:system.
If JVM_IsUseContainerSupport returns FALSE, -XshowSettings:system has
the below output:
Operating System Metrics:
No metrics available for this platform
If JVM_IsUseContainerSupport returns TRUE, -XshowSettings:system has
the below output:
Operating System Metrics:
Provider: cgroupv2
Effective CPU Count: 8
CPU Period: -1
CPU Quota: -1
CPU Shares: -1
List of Processors: N/A
List of Effective Processors: N/A
List of Memory Nodes: N/A
List of Available Memory Nodes: N/A
Memory Limit: Unlimited
Memory Soft Limit: 0.00K
Memory & Swap Limit: Unlimited
Maximum Processes Limit: Unlimited
Signed-off-by: Babneet Singh <[email protected]>
babsingh
changed the title
pshipton
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #18185.
Currently, in comparison to the RI, OpenJ9 shows a different output for
-XshowSettings:system outside a container because our
JVM_IsUseContainerSupport implementation differs from the RI.
This PR matches the latest RI behaviour for JVM_IsUseContainerSupport.
The RI returns TRUE from JVM_IsUseContainerSupport IFF
-XX:+UseContainerSupport is specified. This option is enabled by
default.
Currently, we return TRUE from JVM_IsUseContainerSupport if
-XX:+UseContainerSupport is specified && we are inside a container.
The return value of JVM_IsUseContainerSupport determines the output
of -XshowSettings:system.
If JVM_IsUseContainerSupport returns FALSE, -XshowSettings:system has
the below output:
If JVM_IsUseContainerSupport returns TRUE, -XshowSettings:system has
the below output:
Port of #18185 for 0.41
Signed-off-by: Babneet Singh [email protected]