Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mark the current thread halted during heapification #18172

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

gacholio
Copy link
Contributor

@gacholio gacholio commented Sep 20, 2023

The current thread may release and reacquire VM access during the heapification process. Marking the current thread halted causes a hang in this case.

Related: #18134

@gacholio gacholio requested a review from tajila September 20, 2023 18:28
@gacholio
Copy link
Contributor Author

Note that no testing currently exercises this code, so compile(s) should be sufficient.

The current thread may release and reacquire VM access during the
heapification process. Marking the current thread halted causes a hang
in this case.

Related: eclipse-openj9#18134

Signed-off-by: Graham Chapman <[email protected]>
@tajila
Copy link
Contributor

tajila commented Sep 20, 2023

jenkins win compile jdk8

@gacholio
Copy link
Contributor Author

jenkins win compile jdk8

I think that's out of order.

@pshipton
Copy link
Member

jenkins compile win jdk8

@tajila
Copy link
Contributor

tajila commented Sep 20, 2023

thanks

@tajila tajila merged commit cda91b3 into eclipse-openj9:master Sep 20, 2023
@gacholio gacholio deleted the heapify branch September 21, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants