Add NullCHK when storing value into NullRestricted field #18094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7ehuo
added
comp:jit
project:valhalla
|
@hzongaro May I ask you to review this change? Thank you! |
hzongaro
reviewed
Sep 8, 2023
test/functional/Valhalla/src/org/openj9/test/lworld/NullRestrictedTypeOptTests.java
Outdated
Show resolved
Hide resolved
test/functional/Valhalla/src/org/openj9/test/lworld/NullRestrictedTypeOptTests.java
Outdated
Show resolved
Hide resolved
This applies to `putfield`, `putstatic`, and `withfield`. Related: eclipse-openj9#17340 Signed-off-by: Annabelle Huo <[email protected]>
a7ehuo
force-pushed
the
fix-missing-check-store-null
branch
from
fd952e6 to
7725103
Compare
|
@hzongaro All comments are addressed. Ready for another review. Thanks! |
|
Jenkins test sanity,extended xlinuxval jdknext |
|
Jenkins test sanity xlinuxvalst jdknext |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add NullCHK when storing value into NullRestricted field.
This applies to
putfield,putstatic, andwithfield.Related: #17340