Define unit tests involving arrays of empty value types #18041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzongaro
added
comp:test
project:valhalla
|
Annabelle @a7ehuo, Hang @hangshao0, may I ask you to review this change? |
|
I'll move it to draft for now, while we're waiting for pull request #17994 to be merged, but I don't expect to make any changes, other than those that might be requested in a review. |
a7ehuo
reviewed
Aug 30, 2023
test/functional/Valhalla/src/org/openj9/test/lworld/ValueTypeArrayTests.java
Outdated
Show resolved
Hide resolved
This change defines some simple unit tests that create arrays of value classes and null restricted value classes, where the classes have no fields. The objective is to ensure that allocation, assignment and comparison of flattened arrays whose elements are of length zero does not result in unexpected failures.
hzongaro
force-pushed
the
test-empty-value-type-array-elements
branch
from
400840e to
6fb2ec1
Compare
|
Jenkins test sanity xlinuxval jdknext |
a7ehuo
approved these changes
Sep 5, 2023
|
Hang @hangshao0, now that pull request #17994 has been merged, I've moved this pull request into "Ready for review" status. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change defines some simple unit tests that create arrays of value classes and null restricted value classes, where the classes have no fields. The objective is to ensure that allocation, assignment and comparison of flattened arrays whose elements are of length zero does not result in unexpected failures.
related to #14027