-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NullRestricted attribute field class checks #18030
Conversation
5b841c7
to
f2025fb
Compare
There are merge conflicts that need to be resolved. |
f2025fb
to
558a22d
Compare
558a22d
to
d3f617e
Compare
c354487
to
19b3767
Compare
@hangshao0 I'm planning to add changes to flatten non-static NullRestricted field classes in another pull request since its not needed for these checks. |
Flags are no longer part of extramodifiers Signed-off-by: Theresa Mammarella <[email protected]>
19b3767
to
3524b01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Jenkins test sanity,extended xlinuxval jdknext |
Jenkins test sanity,extended winval jdknext |
Looking into the failure. edit: linking here so the failure isn't lost https://openj9-jenkins.osuosl.org/job/Test_openjdkValhalla_j9_sanity.functional_x86-64_linux_valhalla_Personal/79/ |
NullRestricted fields must be a value type with an ImplicitCreation attribute that has the ACC_DEFAULT flag set. For non-static fields this should be checked during class creation and for static fields during the preparation stage of linking. This pr also adds static NullRestricted fields to the flattenedClassCache to make the described failure possible. Changes to allow non-static NullRestricted fields to be flattened will come in a later pull request. Signed-off-by: Theresa Mammarella <[email protected]>
3524b01
to
b4bc9cd
Compare
* ImplicitCreation attribute. The attribute must have the ACC_DEFAULT flag set. | ||
* Static fields will be checked during class preparation. | ||
*/ | ||
if (J9_ARE_ALL_BITS_SET(modifiers, J9FieldFlagIsNullRestricted)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot this important line here :) the functional/Valhalla tests are passing for me locally now.
Jenkins test sanity,extended xlinuxval jdknext |
Jenkins test sanity,extended winval jdknext |
Related: #17340