Guard a call to VMwrtbarWithoutStoreEvaluator #18027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xdaryl
reviewed
Sep 6, 2023
| // penalize general runtime performance especially if it is still correct to do | ||
| // a write barrier even if the store never actually happened. | ||
| // | ||
| // A branch |
Guard a call to VMwrtbarWithoutStoreEvaluator (which is only compatible with non-realtime GC) to ensure it is not called under realtime GC. Signed-off-by: Dylan Tuttle <[email protected]>
dylanjtuttle
force-pushed
the
guardNonRealTimeWriteBarrier
branch
from
47a5ac4 to
c6c8af3
Compare
|
Jenkins test sanity xlinux,osx,win jdk17 |
|
Jenkins test sanity.system,sanity.openjdk xlinux,osx,win jdk17 |
0xdaryl
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guard a call to VMwrtbarWithoutStoreEvaluator (which is only compatible with non-realtime GC) to ensure it is not called under realtime GC.
Issue: #15440