Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly ifdef Java19 code #17086

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

fengxue-IS
Copy link
Contributor

Signed-off-by: Jack Lu [email protected]

@fengxue-IS
Copy link
Contributor Author

Fixes compile error introduced by #16855 in pre-Java 19 builds.
Personal build to verify inprogress

@pshipton can you please take a look

@fengxue-IS fengxue-IS requested a review from pshipton March 31, 2023 20:36
@pshipton
Copy link
Member

jenkins compile amac jdk11

@pshipton
Copy link
Member

Since this fixes something, I'll go ahead and merge it. If there are still problems seen in the personal build they can be fixed separately.

@pshipton pshipton merged commit ff024fc into eclipse-openj9:master Mar 31, 2023
@pshipton
Copy link
Member

pshipton commented Mar 31, 2023

Follow up build https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-Personal/366/ - Java 8, 11, 17 compiles all worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants