Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MicroJIT Regression Test Suite #16726

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

harpreetbamrah
Copy link
Contributor

Regression tests for the MicroJIT compiler #9578
See also:
ibmruntimes/openj9-openjdk-jdk8#413
Issue #9582

harpreetbamrah and others added 4 commits February 15, 2023 12:11
Co-authored-by: Eric Coffin <[email protected]>
Co-authored-by: Julie Brown <[email protected]>
Co-authored-by: Shubham Verma <[email protected]>
Co-authored-by: Aaron Graham <[email protected]>
Co-authored-by: Scott Young <[email protected]>
Signed-off-by: Harpreet Kaur <[email protected]>
Signed-off-by: Harpreet Kaur <[email protected]>
Signed-off-by: Harpreet Kaur <[email protected]>
@llxia
Copy link
Contributor

llxia commented Feb 27, 2023

Copyright error is about .class files and junit.jar. https://openj9-jenkins.osuosl.org/job/PullRequest-CopyrightCheck-OpenJ9/8096/console
We should not deliver .class file and 3rd party jar into the openj9 repo.

@harpreetbamrah
Copy link
Contributor Author

Copyright error is about .class files and junit.jar. https://openj9-jenkins.osuosl.org/job/PullRequest-CopyrightCheck-OpenJ9/8096/console We should not deliver .class file and 3rd party jar into the openj9 repo.

Hi Lan, thanks for the clarification!
Actually we need JUnit 5 framework for running MicroJIT tests, hence the jar file as the TKG has JUnit 4. What could be a possible wayout for that?

@llxia
Copy link
Contributor

llxia commented Mar 6, 2023

@harpreetbamrah we can add junit5 jar download url in https://github.com/adoptium/TKG/blob/master/scripts/getDependencies.pl. Similar to junit4 and use it in build.xml

<property name="LIB" value="junit4,asm_all,jcommander,testng"/>
<import file="${TEST_ROOT}/TKG/scripts/getDependencies.xml"/>

<target name="compile_generator" depends="init,getDependentLibs" description="Compile SimpleIndyGenerator">

@harpreetbamrah
Copy link
Contributor Author

@harpreetbamrah we can add junit5 jar download url in https://github.com/adoptium/TKG/blob/master/scripts/getDependencies.pl. Similar to junit4 and use it in build.xml

<property name="LIB" value="junit4,asm_all,jcommander,testng"/>
<import file="${TEST_ROOT}/TKG/scripts/getDependencies.xml"/>

<target name="compile_generator" depends="init,getDependentLibs" description="Compile SimpleIndyGenerator">

Hi Lan, do we need a separate pull request to add JUnit 5 jar to TKG?

@llxia
Copy link
Contributor

llxia commented Mar 16, 2023

Yes, we need separate PR in TKG for downloading junit5 jar. An example is in #16726 (comment)

Also, we have to clean up .class files in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants