-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MicroJIT Regression Test Suite #16726
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Eric Coffin <[email protected]> Co-authored-by: Julie Brown <[email protected]> Co-authored-by: Shubham Verma <[email protected]> Co-authored-by: Aaron Graham <[email protected]> Co-authored-by: Scott Young <[email protected]> Signed-off-by: Harpreet Kaur <[email protected]>
Signed-off-by: Harpreet Kaur <[email protected]>
Signed-off-by: Harpreet Kaur <[email protected]>
Signed-off-by: Harpreet Kaur <[email protected]>
Copyright error is about .class files and junit.jar. https://openj9-jenkins.osuosl.org/job/PullRequest-CopyrightCheck-OpenJ9/8096/console |
Hi Lan, thanks for the clarification! |
@harpreetbamrah we can add junit5 jar download url in https://github.com/adoptium/TKG/blob/master/scripts/getDependencies.pl. Similar to junit4 and use it in build.xml openj9/test/functional/Jsr292/build.xml Lines 43 to 44 in b975e82
openj9/test/functional/Jsr292/build.xml Line 52 in b975e82
|
Hi Lan, do we need a separate pull request to add JUnit 5 jar to TKG? |
Yes, we need separate PR in TKG for downloading junit5 jar. An example is in #16726 (comment) Also, we have to clean up .class files in the PR. |
Regression tests for the MicroJIT compiler #9578
See also:
ibmruntimes/openj9-openjdk-jdk8#413
Issue #9582