Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asserts fired due to PROD_WITH_ASSUMES commented out #15509

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Asserts fired due to PROD_WITH_ASSUMES commented out #15509

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98e8900
Asserts fired due to PROD_WITH_ASSUMES commented out
manashaVetrivelu Jul 8, 2022
24006dc
Asserts fired due to PROD_WITH_ASSUMES commented out
manashaVetrivelu Jul 13, 2022
f317dc3
Asserts Due to PROD_WITH_ASSUMES
manashaVetrivelu Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion runtime/compiler/control/CompilationThread.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11599,7 +11599,8 @@ TR::CompilationInfo::replenishInvocationCount(J9Method *method, TR::Compilation
}
else
{
TR_ASSERT(false, "Unexpected value for method->extra = %p (method=%p)\n", TR::CompilationInfo::getJ9MethodExtra(method), method);
//assert below is commented because it is fired when compiled with PROD_WITH_ASSUMES
//TR_ASSERT(false, "Unexpected value for method->extra = %p (method=%p)\n", TR::CompilationInfo::getJ9MethodExtra(method), method);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to further investigate this case

}
}

Expand Down
2 changes: 1 addition & 1 deletion runtime/compiler/infra/J9MonitorTable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2021 IBM Corp. and others
* Copyright (c) 2000, 2022 IBM Corp. and others
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file only has the date in the copyright changed. We can skip it.

*
* This program and the accompanying materials are made available under
* the terms of the Eclipse Public License 2.0 which accompanies this
Expand Down
3 changes: 2 additions & 1 deletion runtime/compiler/x/codegen/J9TreeEvaluator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10776,7 +10776,8 @@ void J9::X86::TreeEvaluator::VMwrtbarWithoutStoreEvaluator(
{
TR::Compilation *comp = cg->comp();
TR_J9VMBase *fej9 = (TR_J9VMBase *)(cg->fe());
TR_ASSERT(!(comp->getOptions()->realTimeGC()),"Call the real-time barrier");
//assert below is commented because it is fired when compiled with PROD_WITH_ASSUMES
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest something like:
// Temporarily disable the asset below until we figure out the root cause

//TR_ASSERT(!(comp->getOptions()->realTimeGC()),"Call the real-time barrier");
auto gcMode = TR::Compiler->om.writeBarrierType();

if (node->getOpCode().isWrtBar() && node->skipWrtBar())
Expand Down