Assert dstObj in arraycopyEval is not a dataAddrPtr in P/AArch64 #7500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For OffHeap, the arraycopy transformations uses the correct base object as the dstObj node, instead of the dataAddrPtr load.
To ensure correctness this PR adds an asserts that checks that the dstObj is not a dataAddrPtr.
Reason being the writeBarrier code assumes the dstObj node being the base object and uses that for card-dirtying address calculation.
Following: eclipse-openj9/openj9#20264
X/Z in OpenJ9: eclipse-openj9/openj9#20480