Export file_get_unicode_path() through omrportptb.h #3553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Rename file_get_unicode_path() to port_file_get_unicode_path(). 2. Similar to port_convertFromUTF8(), export port_file_get_unicode_path() so that it can be used if we need to know the file unicode path on Windows. Related to eclipse-openj9/openj9#4351 Signed-off-by: hangshao <[email protected]>
|
@genie-omr build all |
|
https://ci.eclipse.org/omr/job/PullRequest-win_x86-64/851/console Failed to launch the build. @youngar |
|
I didn't launch the windows build properly, but it passed here: https://ci.eclipse.org/omr/job/PullRequest-win_x86-64/857/console |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port_file_get_unicode_path() so
that it can be used if we need to know the file unicode path on Windows.
Related to eclipse-openj9/openj9#4351
Signed-off-by: hangshao [email protected]