-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit lucene version #389 #390
Conversation
Task-Url: #376
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have strong objections.
WDYT @merks ?
Give me a few minutes. I'd like to understand how this is possible. |
It's possible you may have clean up some bad conversions |
I don't know which project had the error being fixed: I don't have a big objection to doing what's necessary to fix the errors, but it all seems very strange to me. |
Not having lower boundary opens the door for a case where the package is there but the API is not what we expect. I understand this is quite unlikely as Platform will bring new enough Lucene in most products but still something to be considered. |
org.apache.lucene.search;version="9.5.0", | ||
org.apache.lucene.store;version="9.5.0", | ||
org.apache.lucene.util;version="9.5.0" | ||
Import-Package: org.apache.lucene.analysis;version="0.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not use a version of 0.0.0 here, thats the default and only highly confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately the discussion is split better the PR and the issue. I think the appropriate fix is what I show here:
I don't understand what this should fix either... 9.5.0 is a open range and includes every higher version (including 9.5.1), this fix looks suspicious and more likely is a sign of wrong dependency chains. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gnl42 what if try to import Lucene package(s) for bundles that started to require it after clean-up?
Adding explicit import to the test project seems to fix the issue. Somthing to watch out for |
Nooo please see my comment please check if you need to update the BREE instead! |
Strange missing class error after doing a Clean Up of Tasks
Tasks is using an explicit reference to 9.5.0, p2 -> 9.5.1.
Changing the version to 0.0 .0 clears the error
Task-Url: #389