[Core] delete now obsolete nexus-cache directory #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mickaelistria do you have any objections here? |
|
No objection, but can you please figure out if Jenkins failure is related and either fix commit, or retrigger the build to get a nice green checkmark? |
HannesWell
force-pushed
the
deleteNexusCache
branch
from
0009915
to
a717e95
Compare
Sure! I suspect the second failing build was because I accidentally first pushed the branch from this PR to the m2e-core repo instead of my fork. I deleted it immediately but Jenkins somehow still considered it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #509 (comment) this PR enhances the Activator of
o.e.m2e.coreto delete the now obsolete nexus-cache directory on start-up (if it exists).This can free a lot of disk-space for users that had downloaded the index (like me, where the nexus folder occupied almost 5GB per workspace!).
Besides that this PR fixes a little error in the m2e.core Manifest and bumps the
m2e-testssub-module reference.