Perform Maven target dependency update in non-UI thread #1901
+76
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 321 files ±0 321 suites ±0 54m 38s ⏱️ + 3m 32s For more details on these errors, see this check. Results for commit 7a69cf7. ± Comparison against base commit 02d733c. This pull request removes 1 test.♻️ This comment has been updated with latest results. |
ptziegler
force-pushed
the
non-blocking-maven-update
branch
3 times, most recently
from
f49b773
to
1a4d43c
Compare
ptziegler
commented
Nov 28, 2024
| @@ -316,7 +312,7 @@ public void testUpdateMavenArtifactVersion() throws Exception { | |||
|
|
|||
| table.select(12); | |||
| robot.button("Update").click(); | |||
| readAndDispatch(); | |||
There was a problem hiding this comment.
The test is executed too fast. Because the update is now done in a separate thread, we get the "The wizard can't be closed because of an active operation" popup when trying to close it.
ptziegler
force-pushed
the
non-blocking-maven-update
branch
from
1a4d43c
to
fdb0de1
Compare
Depending on how many artifacts are updated, this might be a long-running operation and should therefore be run without blocking the application.
ptziegler
force-pushed
the
non-blocking-maven-update
branch
from
fdb0de1
to
7a69cf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on how many artifacts are updated, this might be a long-running operation and should therefore be run without blocking the application.