Update to latest monaco-editor-wrapper and monaco-editor-react #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaisalmen
force-pushed
the
feature/wrapper-v3
branch
2 times, most recently
from
f386f48 to
ed10438
Compare
kaisalmen
changed the title
kaisalmen
force-pushed
the
feature/wrapper-v3
branch
from
ed10438 to
2b7e861
Compare
kaisalmen
force-pushed
the
feature/wrapper-v3
branch
from
2b7e861 to
54d2e9e
Compare
This was referenced Oct 18, 2023
- Extract/Add package langium-website-foundation
kaisalmen
force-pushed
the
feature/wrapper-v3
branch
from
54d2e9e to
05e5ce1
Compare
montymxb
requested changes
Oct 20, 2023
There was a problem hiding this comment.
- We should update the README to explain the purpose of the new package, and how it fits into the greater flow.
- Add a README to the new package itself, just to summarize it very briefly
Separately, I would consider core instead of foundation for the package name.
|
All things are addressed. |
montymxb
approved these changes
Oct 20, 2023
approved! Changes look good, and verified locally.
emilkrebs
pushed a commit
that referenced
this pull request
Oct 25, 2023
* Update to latest monaco-editor-wrapper and monaco-editor-react * Implemented review comments
emilkrebs
added a commit
that referenced
this pull request
Oct 26, 2023
* fixed nested elements and scaling * remaned one function * fixed a renaming problem * Fix typo in getting-started grammar (#198) * Fix typo in getting-started grammar * Make code blocks vertically scrollable To make it possible to read the docs on a phone * Update Langium + Monaco Tutorials (#192) * update of langium + monaco tutorial * update generation in the web tutorial * Update to latest monaco-editor-wrapper and monaco-editor-react (#196) * Update to latest monaco-editor-wrapper and monaco-editor-react * Implemented review comments * fixed a renaming problem --------- Co-authored-by: Vit Gottwald <[email protected]> Co-authored-by: Benjamin Friedman Wilson <[email protected]> Co-authored-by: Kai Salmen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the user config / app init code and any dependent code. The whole init and utility code regarding
monaco-editor-wrapperand@typefox/monaco-editor-reactand its bundle generation has been moved to its own package: langium-website-coreHugo code only uses that bundle which prevents any complex javascript issues when generating the site.
All showcases and the playground work again!
This PR now uses the final version
3.3.0ofmonaco-editor-wrapperand2.3.0of@typefox/monaco-editor-react