feat(web2): Added dynamic validator for scale and offset fields #5530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salvatore-coppola
force-pushed
the
scale-offset-to-string-type
branch
from
9b4f106
to
41e55f7
Compare
salvatore-coppola
force-pushed
the
scale-offset-to-string-type
branch
from
3621d50
to
ccbc936
Compare
|
|
||
| public String getValue(String id); | ||
| public String getValue(Integer index); |
There was a problem hiding this comment.
Why you changed the way the resource is got? Key vs. index?
There was a problem hiding this comment.
It was required to extract the LegacyChannelModel if I'm not wrong. The class was a mess
| /** | ||
| * This is a copy of {@code org.eclipse.kura.type.DataType} | ||
| */ | ||
|
|
There was a problem hiding this comment.
Why you needed to copy this class?
There was a problem hiding this comment.
Because we need it in the client part of webui
| * Scale and Offset. | ||
| * | ||
| * This is a copy of {@code org.eclipse.kura.channel.ScaleOffsetType} | ||
| * |
There was a problem hiding this comment.
Same question here.
There was a problem hiding this comment.
Because we need it in the client part of webui
salvatore-coppola
force-pushed
the
scale-offset-to-string-type
branch
from
ccbc936
to
fb73cd0
Compare
pierantoniomerlino
approved these changes
Nov 22, 2024
|
Forcing merge. The build has passed. Right now the rebase is failing on other flaky tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now scale and offset fields in the asset's channel table are validated according to the mode calculated for the channel as described here.