Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the unified GH workflow to JDT UI #955

Closed

Conversation

vogella
Copy link
Contributor

@vogella vogella commented Dec 1, 2023

Lets also use the commmon GH action flow like in PDE in JDT. This should help to discover issues in JDT UI faster and help to identfiy flacky tests.

What it does

How to test

Author checklist

Lets also use the commmon GH action flow like in PDE in JDT. This should
help to discover issues in JDT UI faster and help to identfiy flacky
tests.
@vogella
Copy link
Contributor Author

vogella commented Dec 1, 2023

@laeubi can you check, the common setup is your "baby" if IIRC.

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 97a8bac.

@laeubi
Copy link
Contributor

laeubi commented Dec 1, 2023

@vogella
Copy link
Contributor Author

vogella commented Dec 1, 2023

Ups sorry the replicate.

@vogella vogella closed this Dec 1, 2023
@laeubi
Copy link
Contributor

laeubi commented Dec 1, 2023

@vogella you can still help making that one "work" I just left it "as-is" as there is not much interest from JDT team in apply this ...

@vogella
Copy link
Contributor Author

vogella commented Dec 1, 2023

@vogella you can still help making that one "work" I just left it "as-is" as there is not much interest from JDT team in apply this ...

With @akurtakov we now have a person in JDT which is interested in build automation and improvements so it might start to move. JDT seems to suffer from a lot of instability lately, I assume they start paying the price for not investing into community and code simplifications.

@iloveeclipse
Copy link
Member

we now have a person in JDT which is interested in build automation and improvements

Good, finally! I assume the rest JDT committers us are simply not interested in any improvements and for sure in no automations. I would prefer you would not post such offending and insulting comments in the future.

JDT seems to suffer from a lot of instability lately

Please provide a pointer to this claim.

@vogella
Copy link
Contributor Author

vogella commented Dec 1, 2023

we now have a person in JDT which is interested in build automation and improvements

Good, finally! I assume the rest JDT committers us are simply not interested in any improvements and for sure in no automations. I would prefer you would not post such offending and insulting comments in the future.

#536 is from April and the contributor @laeubi said "s there is not much interest from JDT team in apply this ...". Also JDT UI did not even have a pomless build until I contributed one yesterday. Nor does JDT core. If that means that JDT is actively working on build improvements that I fear we have a different standard for such work.

I know you fight very hard to keep the build up and stable, so sorry if you were insulted. But I do not see a lot of releng improvements from other JDT people.

JDT seems to suffer from a lot of instability lately

Please provide a pointer to this claim.

Just a feeling so I might be wrong here and I was under the impression that we see a lot of JDT build issues in the last days?

@vogella vogella deleted the using-common-gh-flow branch December 1, 2023 10:34
@iloveeclipse
Copy link
Member

Just a feeling so I might be wrong here and I was under the impression that we see a lot of JDT build issues in the last days?

Yes, your feelings are wrong here. The troubles we have are usual if we have ~50 PR's merged in a day right after freeze.

@vogella
Copy link
Contributor Author

vogella commented Dec 1, 2023

Just a feeling so I might be wrong here and I was under the impression that we see a lot of JDT build issues in the last days?

Yes, your feelings are wrong here. The troubles we have are usual if we have ~50 PR's merged in a day right after freeze.

Good to hear. I will now continue to help JDT in releng work instead on continuing this discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants