Push various javadoc generation code into jdt.core.manipulations #941
Conversation
|
This PR is not clean or ready to go. It is a test to see whether the changes I've made so far have broken any test cases or otherwise messed up existing functionality. |
robstryker
force-pushed
the
wip_javadoc_pushdown
branch
3 times, most recently
from
9dbddaa to
14f06d8
Compare
|
This PR actually depends on eclipse-platform/eclipse.platform.ui#1334 and, once 1334 is merged, this PR will need to be modified to remove the duplicate classes. They were only placed in this PR so that I could have the build system run the test suite repeatedly. |
robstryker
force-pushed
the
wip_javadoc_pushdown
branch
4 times, most recently
from
8943ac6 to
371f957
Compare
robstryker
force-pushed
the
wip_javadoc_pushdown
branch
3 times, most recently
from
e5f89f5 to
716abd5
Compare
...on/common/org/eclipse/jdt/core/manipulation/internal/javadoc/CoreJavaDoc2HTMLTextReader.java
Show resolved
Hide resolved
....manipulation/common/org/eclipse/jdt/core/manipulation/internal/javadoc/JavaDocMessages.java
Show resolved
Hide resolved
|
I can have a look probably by end of the week unless someone gets to it before me. |
robstryker
changed the title
robstryker
force-pushed
the
wip_javadoc_pushdown
branch
from
55a00cf to
db1ad85
Compare
Signed-off-by: Rob Stryker <[email protected]> WIP - push down and break up logic for javadoc html generation Signed-off-by: Rob Stryker <[email protected]> Comment out unused methods Signed-off-by: Rob Stryker <[email protected]> Upversion some stuff Signed-off-by: Rob Stryker <[email protected]> Upversion some stuff Signed-off-by: Rob Stryker <[email protected]> Bad since tag Signed-off-by: Rob Stryker <[email protected]> Compilation error Signed-off-by: Rob Stryker <[email protected]> Revert "TEMPORARY patch to allow access to expected org.eclipse.text classes. Revert before merge" This reverts commit ebe0ea8. TEMPORARY patch to allow access to expected org.eclipse.text classes. Revert before merge Signed-off-by: Rob Stryker <[email protected]> JDT null check Bugfix for test suite Signed-off-by: Rob Stryker <[email protected]> Some cleanup, delete commented out implementations, etc Signed-off-by: Rob Stryker <[email protected]> Fix a jdt.ls test case, revert if breaks jdt Signed-off-by: Rob Stryker <[email protected]> Continue work for abstraction points for jdt.ls, copy temporary changes to org.eclipse.text packages Signed-off-by: Rob Stryker <[email protected]> Revert "Work around API tooling warning regarding unnecessary minor bump." This reverts commit 19a3a48. Make changes to temporary files to get a green build Signed-off-by: Rob Stryker <[email protected]> Remove temporary workarounds and clean up code Signed-off-by: Rob Stryker <[email protected]> Organize whitespace, remove unused strings Signed-off-by: Rob Stryker <[email protected]> viewsupport package needs split package flag Signed-off-by: Rob Stryker <[email protected]>
robstryker
force-pushed
the
wip_javadoc_pushdown
branch
from
db1ad85 to
d216470
Compare
I'm reviewing it now |
| } | ||
|
|
||
| record SuperclassReferenceMethodData(ArrayList<IMethod> superInterfaceMethods, IMethod superClassMethod) { | ||
| }; |
There was a problem hiding this comment.
i am trying to get ecj warnings away, could you please help, by at least not check in new warnings?
i'll fix this
There was a problem hiding this comment.
@jukzi Maybe you can try putting smth like eclipse-pde/eclipse.pde#990 in JDT ? Until tools are activley complaining don't see things improving.
There was a problem hiding this comment.
@jukzi Sorry, I didn't see it.
There was a problem hiding this comment.
not your fault. I am working on github shows that warning too, so reviewer can see it
What it does
How to test
Author checklist