Make CoreJavadocAccessImpl more extendable for jdt.ls

[robstryker]

What it does

#1351 seems to have fixed an inadvertent change to the value of some constants in a file that was being abstracted out for subclassing.

It's clear that the abstraction process was incomplete and only appeared complete because of these changed constants. The reversion of those constants to their historical value has revealed that jdt.ls cannot override the behavior as expected.

In an attempt to allow jdt.ls to override these values, this PR will make getters for the 6 values, which subclasses may override. All references to those constants in this file can be changed to make use of the getters instead.

This should allow jdt.ls more flexibility in overriding these values and using different formatting as they require.

How to test

This commit should not change current behavior. The test as performed in #1351 should be sufficient to see that no changes in behavior are observed.

Author checklist

• I have thoroughly tested my changes
• The change is following the coding conventions
• I have signed the Eclipse Contributor Agreement (ECA)

[robstryker]

@iloveeclipse Hi Andrey: Your feedback on this issue is welcome / appreciated.

[iloveeclipse]

Hi Andrey: Your feedback on this issue is welcome / appreciated.

Looks OK, please just make sure search/replace hit the right places :)

[robstryker]

If I comment out the declaration of the constants, the only errors are in those getters, so, looks like I didn't miss any uses.

Verified line by line that the proper replacements were made, and that the getters return the correct constant.