Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eclipse-platform/.github#27: Use CTabFolder to improve Dark Theme on Windows #126

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Conversation

betamaxbandit
Copy link
Contributor

@betamaxbandit betamaxbandit commented Jun 27, 2022

improve Dark Theme on Windows eclipse-platform/.github#27

Using CTabFolder and CTabItem, instead of TabFolder/TabItem, improves the look when in Dark Theme; the background of the tab no longer has a non-dark background.

This relates to multiple commits to fix:

[Windows][Dark theme] Multiple preference pages use tab widgets, that are not dark theme aware eclipse-platform/.github#27

@betamaxbandit
Copy link
Contributor Author

To Test:

  1. Launch an eclipse workbench.
  2. Create a Java project and provide a project name, use defaults for rest of settings and click Finish.
  3. In Preferences > General > Appearance > Theme, choose Dark and click Apply and Close. Restart the workbench when prompted.
  4. In Package Explorer, select the project and choose Project > Properties.
  5. In the left hand side navigator, select Java Build Path.
    Expected: the Java Build Path page is displayed and tabs (eg: Source, Projects, Libraries, etc) are displayed correctly. The background of the tabs is shown using the Dark Theme colour.
  6. Repeat from step 3) and change the Theme to Light.
    Expected: the Java Build Path page is displayed and tabs (eg: Source, Projects, Libraries, etc) are displayed correctly. The background of the tabs is shown using the Light Theme colour.

Before and After screencaptures:
Java Build Path - Dark Theme - before

Java Build Path - Dark Theme - after

Java Build Path - Light Theme - before

Java Build Path - Light Theme - after

@betamaxbandit
Copy link
Contributor Author

@jonahgraham

Copy link
Contributor

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me (and follows the same style as similar changes, like eclipse-platform/eclipse.platform.team#14) - but the metadata needs some updating. The commit message should reference the full path to the issue, i.e. eclipse-platform/.github#27

Note the current message makes a bad cross reference to #27 by having eclipse.jdt.ui eclipse-jdt#27 in it.

Please update the commit message and the summary of the pull request.

@jonahgraham
Copy link
Contributor

Also (as discussed offline) the email address used for the commit needs to be the one associated with your Eclipse Account + ECA so that the ECA validation passes.

Using CTabFolder and CTabItem, instead of TabFolder/TabItem, improves
the look when in Dark Theme; the background of the tab no longer has a
non-dark background.

This relates to multiple commits to fix:

[Windows][Dark theme] Multiple preference pages use tab widgets, that
are not dark theme aware eclipse-platform/.github#27
@jjohnstn jjohnstn merged commit e9a3635 into eclipse-jdt:master Jul 25, 2022
@betamaxbandit
Copy link
Contributor Author

@jjohnstn , thank you for merging.
Cheers John Moule

@betamaxbandit betamaxbandit changed the title eclipse.jdt.ui #27: Use CTabFolder to improve Dark Theme on Windows eclipse-platform/.github#27: Use CTabFolder to improve Dark Theme on Windows Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants