fix search.matching.MatchLocator.bindings #3418 #3522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A map with keys char[] did only find keys by identity (but not by equal characters as needed). eclipse-jdt#3418 tested by RunJavaSearchTests
|
Wouldn't this cause more memory pressure and more GC work by creating new Strings, how often is this code used and in which context? Is this index related? I haven't checked this in the IDE. |
|
This PR can even reduce memory pressure (and computational effort) as equal char[] are not stored multiple times in the Map. Not only are equal keys avoided but also their TypeBinding values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A map with keys char[] did only find keys by identity (but not by equal characters as needed).
#3418
tested by RunJavaSearchTests