[Sealed Types] Permits clause handling in scanner and parser is unnecessarily complicated #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unnecessarily complicated * Fixes eclipse-jdt#2652
srikanth-sankaran
added a commit
to srikanth-sankaran/eclipse.jdt.core
that referenced
this pull request
Jul 4, 2024
srikanth-sankaran
added a commit
to srikanth-sankaran/eclipse.jdt.core
that referenced
this pull request
Jul 5, 2024
srikanth-sankaran
added a commit
that referenced
this pull request
Jul 5, 2024
…", permits expected * Revert #2653 for now * Update qualifier for performance tests project * Regression test
robstryker
pushed a commit
to robstryker/eclipse.jdt.core
that referenced
this pull request
Jul 18, 2024
…essarily complicated (eclipse-jdt#2653) * Fixes eclipse-jdt#2652
robstryker
pushed a commit
to robstryker/eclipse.jdt.core
that referenced
this pull request
Jul 18, 2024
…", permits expected * Revert eclipse-jdt#2653 for now * Update qualifier for performance tests project * Regression test
gayanper
pushed a commit
to gayanper/eclipse.jdt.core
that referenced
this pull request
Sep 7, 2024
…essarily complicated (eclipse-jdt#2653) * Fixes eclipse-jdt#2652
gayanper
pushed a commit
to gayanper/eclipse.jdt.core
that referenced
this pull request
Sep 7, 2024
…", permits expected * Revert eclipse-jdt#2653 for now * Update qualifier for performance tests project * Regression test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
How to test
Author checklist