Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: issue optional warning using '==' for wrapper types #2188

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
be4d139
feat: issue optional warning using '==' for wrapper types
dashorst Mar 20, 2024
5d9a86e
refactor: ComparingWrapper constant -> 1202
dashorst Apr 6, 2024
33b3448
docs: clarify ComparingWrapper detection of boxed types
dashorst Apr 6, 2024
f4e2db9
refactor: use already available severity computation
dashorst Apr 6, 2024
221dcd4
refactor: rename to unlikely equal expression argument type
dashorst Apr 6, 2024
dcd55f0
fix: also rename compiler option and document it
dashorst Apr 6, 2024
0784fef
refactor: UnlikelyEqualExpressionArgumenType -> UnlikelyReferenceComp…
dashorst Apr 8, 2024
389bdfb
refactor: add operator to unlikelyReferenceComparison message
dashorst Apr 8, 2024
b3140c8
fix: CompilerInvocationTests
dashorst Apr 8, 2024
4b3c272
feat: add support for more reference comparison detections
dashorst Apr 8, 2024
384a8ae
fix: UnlikelyReferenceComparison with null should not warn
dashorst Apr 9, 2024
843cc58
test: Ignore unlikely reference comparison in AssignmentTest
dashorst Apr 9, 2024
2eaf0f3
test: Ignore unlikely reference comparison in CastTest
dashorst Apr 9, 2024
ee3fa2d
test: ignore unlikely reference comparison in AutoBoxingTest
dashorst Apr 12, 2024
4372822
test: replace comparingWrapper with unlikelyReferenceComparison in Ba…
dashorst Apr 12, 2024
b07953b
fix: change default of unlikelyReferenceComparison to INFO in Irritan…
dashorst Apr 12, 2024
94fd84b
test: ignore unlikely reference comparison in NegativeLambdaExpressio…
dashorst Apr 12, 2024
89ea49a
test: fix BatchCompilerTest (correctly identified unlikely comparison)
dashorst Apr 12, 2024
b3cf7e2
refactor: unlikelyReferenceComparison -> dubiousReferenceComparison
dashorst May 9, 2024
d4eb747
fix: test runner gave errors on non-normalized paths
dashorst May 9, 2024
df2ef7e
fix: give better test failure messages
dashorst May 9, 2024
d6393d1
Update warning message from Unlikely -> Dubious
dashorst May 9, 2024
3c0d8ac
test: Normalise path differences in assertion
dashorst May 12, 2024
2ec884d
refactor: implement review comments
dashorst May 18, 2024
bf2fec3
clean: remove duplicate entry in CompilerOptions
dashorst May 18, 2024
5d54c68
Merge branch 'master' into dashorst:issue_2176
stephan-herrmann Jun 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,8 @@ protected void runTest(boolean shouldCompileOK, String[] testFiles, Object extra
"Unexpected error output for invocation with arguments ["
+ extraArguments + "]",
expectedErrOutputString,
errOutputString);
outputDirNormalizer
.normalized(errOutputString));
dashorst marked this conversation as resolved.
Show resolved Hide resolved
}
}

Expand Down