fix zipSlip .. regression #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jukzi
force-pushed
the
zipSlipRegression
branch
from
5cd0b7d to
e26641d
Compare
sratz
reviewed
Mar 20, 2024
|
|
||
| public static String getEntryName(String zipfileName, ZipEntry entry) { | ||
| String entryName = entry.getName(); | ||
| if (!java.nio.file.Path.of(zipfileName, entryName).normalize() |
There was a problem hiding this comment.
I was confused at first how Path would be able to handle zip entries, but you're just using the Path API to handle normalization and startsWith() in a semantically correct way (not String.startsWith()).
Neat trick! Looks good
|
Is this ready to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2015 (comment)