Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[memory] Deduplicate new Strings #2054 #2058

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Feb 22, 2024

Reduces memory used by type hierarchy / call hierarchy. Stored for example in ResolvedBinaryType.uniqueKey

#2054

@jukzi
Copy link
Contributor Author

jukzi commented Feb 22, 2024

For example in platform workspace a heap dump after a quick type hierarchy on java.lang.Object is reduced by ~ 200MB due to less Duplicate Strings and Duplicate Arrays:
Heapdump without Change:
image
Heapdump with Change:
image

@jukzi jukzi force-pushed the Deduplicate_new_Strings branch 4 times, most recently from 3da1013 to ce34804 Compare February 23, 2024 16:25
Reduces memory used by type hierarchy / call hierarchy.
Stored for example in ResolvedBinaryType.uniqueKey

eclipse-jdt#2054
@jukzi jukzi force-pushed the Deduplicate_new_Strings branch from ce34804 to 8897ebc Compare March 5, 2024 07:12
@jukzi jukzi merged commit b16f949 into eclipse-jdt:master Mar 5, 2024
9 checks passed
@jukzi jukzi deleted the Deduplicate_new_Strings branch March 5, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants