Compute problems #2052
Closed
Compute problems #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having root unit set in the lookupEnvironment (when focusing on a single unit) can be necessary for further binding resolution. Fixes eclipse-jdt#1915
Introduced 2 system property switches to control whether some IDE operations are using ECJ parser (legacy/default) or whether to make those operations powered by a full DOM. * CompilationUnit.DOM_BASED_OPERATIONS will make codeSelect (hover, link to definition...), buildStructure (JDT Project element model), reconciler (code diagnostics feedback); this one seems currently working ✔ * CompilationUnit.codeComplete.DOM_BASED_OPERATIONS controls completion (unlike other operations, completion based on DOM is far from being complete or straightforward) 🏗️ * SourceIndexer.DOM_BASED_INDEXER controls whether the indexation of a source document should first build/use a full DOM. This one is currently incomplete 🏗️ The DOM-based operation can then allow to plug alternative compiler then ECJ and still get JDT functionalities working.
Addresses NPE in JavaSearchTests.testEnum04 Signed-off-by: David Thompson <[email protected]>
Adds some steps on the relevant branches, so the necessary system properties are set in tests to enable DOM-first and Javac.
[DOM to Model] Support default value, deprecated, and more - Use modifiers instead of flags to populate `MemberElementInfo.flags` (the field and setter are misnamed, it contains the modifiers) - Call code that searches for @deprecated annotation on all body declarations - Cache calls to check for an imported class called `Deprecated` so that it doesn't happen multiple times Signed-off-by: David Thompson <[email protected]>
…onUnitTests` (eclipse-jdt#21) * Re-enable populating Enum constants Signed-off-by: David Thompson <[email protected]>
- Fixes ASTModelBridgeTests.testFindElement05 - Fixes ASTModelBridgeTests.testLocalType - Fixes ASTModelBridgeTests.testLocalType2 Signed-off-by: David Thompson <[email protected]>
- Fixes `ASTModelBridgeTests.testAnonymousType` - Fixes `ASTModelBridgeTests.testAnonymousType2` Signed-off-by: David Thompson <[email protected]>
Signed-off-by: David Thompson <[email protected]>
+ Fix on-demand import name range + Fix TypeParameter name range + Fix some annotation name range + Fix some anonymous source range
Instead of directly calling the problemReporter, try first to add the problems to ASTHolverCUInfo.problems when provided.
Enable resolution when problems are requested as well.
|
Wrong target repo, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
How to test
Author checklist