* toString() output of AST nodes shows up with modifier sealed for

pattern variable declaration * Fixes #2017
eclipse-jdt · Feb 15, 2024 · ca84d91 · ca84d91
1 parent c76d80f
commit ca84d91
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/...e.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/ast/LocalDeclaration.java b/...e.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/ast/LocalDeclaration.java
@@ -361,6 +361,8 @@ public void markInitialized() {
 			// create a binding from the specified type
 			this.binding = new LocalVariableBinding(this, variableType, this.modifiers, false /*isArgument*/);
 		}
+		if (isPatternVariable)
+			this.binding.tagBits |= TagBits.IsPatternBinding;
 		scope.addLocalVariable(this.binding);
 		this.binding.setConstant(Constant.NotAConstant);
 		// allow to recursivelly target the binding....

diff --git a/...clipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/ast/TypePattern.java b/...clipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/ast/TypePattern.java
@@ -127,7 +127,6 @@ public TypeBinding resolveType(BlockScope scope) {
 		if (this.resolvedType != null)
 			return this.resolvedType; // Srikanth, fix reentry
 
-		this.local.modifiers |= ExtraCompilerModifiers.AccOutOfFlowScope;
 		Pattern enclosingPattern = this.getEnclosingPattern();
 		if (this.local.type == null || this.local.type.isTypeNameVar(scope)) {
 			/*
@@ -161,7 +160,6 @@ public TypeBinding resolveType(BlockScope scope) {
 		this.local.resolve(scope, true);
 		if (this.local.binding != null) {
 			this.local.binding.modifiers |= ExtraCompilerModifiers.AccOutOfFlowScope; // start out this way, will be BlockScope.include'd when definitely assigned
-			this.local.binding.tagBits |= TagBits.IsPatternBinding;
 			if (enclosingPattern != null)
 				this.local.binding.useFlag = LocalVariableBinding.USED; // syntactically required even if untouched
 			if (this.local.type != null)

diff --git a/...dt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/problem/ProblemReporter.java b/...dt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/problem/ProblemReporter.java
@@ -3188,7 +3188,7 @@ public void illegalModifierForMethod(AbstractMethodDeclaration methodDecl) {
 }
 public void illegalModifierForVariable(LocalDeclaration localDecl, boolean complainAsArgument) {
 	String[] arguments = new String[] {new String(localDecl.name)};
-	int problemId = ((localDecl.modifiers & ExtraCompilerModifiers.AccOutOfFlowScope) != 0) ?
+	int problemId = localDecl.binding.isPatternVariable() ?
 			IProblem.IllegalModifierForPatternVariable :
 			(complainAsArgument
 					? IProblem.IllegalModifierForArgument