-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#96] introduce monitoring #99
[#96] introduce monitoring #99
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
- Coverage 77.62% 77.36% -0.27%
==========================================
Files 178 181 +3
Lines 19222 19596 +374
==========================================
+ Hits 14922 15160 +238
- Misses 4300 4436 +136
|
c5978d4
to
c5b3990
Compare
c5b3990
to
baa981d
Compare
…g path or file name
…d normalize functionality to make it consistently hashable and comparable
baa981d
to
ff73855
Compare
7ce9bf6
to
ecf16f6
Compare
ecf16f6
to
6fbb90f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a question for the process_local
cleaner.
Related to #113, since the names are now used more and more, if you want to change them it should be done in the near future.
I would address this with the next PR. I would like to merge this soon, since it fixes clippy warnings in the CI as well. |
Notes for Reviewer
Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.
Relates to #96