Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#96] introduce monitoring #99

Merged
merged 12 commits into from
Feb 17, 2024

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Jan 27, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.

Relates to #96

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 141 lines in your changes are missing coverage. Please review.

Comparison is base (4c39e70) 77.62% compared to head (e57ab41) 77.36%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   77.62%   77.36%   -0.27%     
==========================================
  Files         178      181       +3     
  Lines       19222    19596     +374     
==========================================
+ Hits        14922    15160     +238     
- Misses       4300     4436     +136     
Files Coverage Δ
iceoryx2-bb/lock-free/src/mpmc/container.rs 94.37% <100.00%> (-0.03%) ⬇️
iceoryx2-bb/posix/src/shared_memory.rs 81.65% <100.00%> (+0.05%) ⬆️
iceoryx2-bb/posix/src/udp_socket.rs 75.79% <100.00%> (+0.05%) ⬆️
iceoryx2-bb/system-types/src/path.rs 85.05% <ø> (ø)
iceoryx2/src/service/builder/mod.rs 80.89% <100.00%> (-0.13%) ⬇️
iceoryx2-cal/src/monitoring/mod.rs 62.50% <62.50%> (ø)
iceoryx2-cal/src/static_storage/file.rs 78.29% <0.00%> (ø)
iceoryx2-cal/src/monitoring/process_local.rs 71.59% <71.59%> (ø)
iceoryx2-cal/src/monitoring/file_lock.rs 56.25% <56.25%> (ø)

... and 3 files with indirect coverage changes

@elfenpiff elfenpiff force-pushed the iox2-96-introduce-monitoring branch 3 times, most recently from c5978d4 to c5b3990 Compare January 27, 2024 12:54
@elfenpiff elfenpiff changed the title (DO NOT REVIEW OR MERGE) [#96] introduce monitoring [Based on PR #97] introduce monitoring Jan 28, 2024
@elfenpiff elfenpiff self-assigned this Jan 28, 2024
@elfenpiff elfenpiff changed the title [Based on PR #97] introduce monitoring [Based on PR #97] DO NOT REVIEW introduce monitoring Feb 6, 2024
@elfenpiff elfenpiff force-pushed the iox2-96-introduce-monitoring branch from c5b3990 to baa981d Compare February 8, 2024 01:23
@elfenpiff elfenpiff force-pushed the iox2-96-introduce-monitoring branch from baa981d to ff73855 Compare February 8, 2024 23:22
@elfenpiff elfenpiff changed the title [Based on PR #97] DO NOT REVIEW introduce monitoring [#96] introduce monitoring Feb 8, 2024
@elfenpiff elfenpiff requested a review from elBoberido February 8, 2024 23:23
@elfenpiff elfenpiff force-pushed the iox2-96-introduce-monitoring branch 5 times, most recently from 7ce9bf6 to ecf16f6 Compare February 9, 2024 00:43
@elfenpiff elfenpiff force-pushed the iox2-96-introduce-monitoring branch from ecf16f6 to 6fbb90f Compare February 9, 2024 00:49
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a question for the process_local cleaner.

Related to #113, since the names are now used more and more, if you want to change them it should be done in the near future.

iceoryx2-cal/src/monitoring/file_lock.rs Show resolved Hide resolved
iceoryx2-cal/src/monitoring/process_local.rs Show resolved Hide resolved
@elfenpiff elfenpiff requested a review from elBoberido February 17, 2024 16:42
@elfenpiff
Copy link
Contributor Author

Looks good. Just a question for the process_local cleaner.

Related to #113, since the names are now used more and more, if you want to change them it should be done in the near future.

I would address this with the next PR. I would like to merge this soon, since it fixes clippy warnings in the CI as well.

@elfenpiff elfenpiff merged commit dfd44b1 into eclipse-iceoryx:main Feb 17, 2024
22 of 23 checks passed
@elfenpiff elfenpiff deleted the iox2-96-introduce-monitoring branch February 17, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants