-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#81] fix signal handler #84
Merged
elfenpiff
merged 3 commits into
eclipse-iceoryx:main
from
elfenpiff:iox2-81-fix-signal-handler
Jan 14, 2024
Merged
[#81] fix signal handler #84
elfenpiff
merged 3 commits into
eclipse-iceoryx:main
from
elfenpiff:iox2-81-fix-signal-handler
Jan 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… since it can have different layouts (linux)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
- Coverage 78.01% 78.00% -0.01%
==========================================
Files 172 172
Lines 18791 18778 -13
==========================================
- Hits 14659 14647 -12
+ Misses 4132 4131 -1
|
elfenpiff
force-pushed
the
iox2-81-fix-signal-handler
branch
from
January 14, 2024 18:34
c965b3b
to
92f4fed
Compare
elfenpiff
commented
Jan 14, 2024
elfenpiff
force-pushed
the
iox2-81-fix-signal-handler
branch
3 times, most recently
from
January 14, 2024 19:04
a7cff2e
to
dbe188a
Compare
elBoberido
reviewed
Jan 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I think you mixed up one variable
elfenpiff
force-pushed
the
iox2-81-fix-signal-handler
branch
from
January 14, 2024 22:08
dbe188a
to
9192cad
Compare
elBoberido
approved these changes
Jan 14, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
The original problem was that I defined a struct
sigaction_t
in rust posix types and reinterpreted it has the posix c typesigaction
, this worked for all platforms, but this was pure luck since posix states nothing about the member order or hidden members. It is not possible to use thesigaction
struct directly from bindgen since some libc implementation have weird C macro hacks. So there are posix libc implementations that strictly speaking violate the posix standard and correct this with a macro calledsa_handler
(the member they renamed to something else).With bindgen it ends up with different struct member names on different libc implementation therefore, there was nothing else possible but to create an
iox2_sigaction
struct inposix.h
and do the translation in the c functioniox2_sigaction_func
since C supports these weird macro hacks in a platform independent way.Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.
Relates to #81