Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#458] cleanup stale windows shm state files #592

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Jan 15, 2025

Notes for Reviewer

On Windows we have to create additional shm state files to track the size of the shared memory. When a process dies, those files keep living - but the shared memory is removed by the OS. So when another instance wants to create a shared memory with the same name, then it thinks it already exists since the stale state file is still around.

With this adjustments, the state file create function checks if the shm is actually present, if not, it deletes the old state file and creates a new one which fixes the issue.

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Relates to #458

@elfenpiff elfenpiff requested a review from elBoberido January 15, 2025 09:55
@elfenpiff elfenpiff self-assigned this Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.17%. Comparing base (1ea0ef5) to head (873590b).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
- Coverage   79.19%   79.17%   -0.02%     
==========================================
  Files         203      203              
  Lines       25373    25373              
==========================================
- Hits        20094    20089       -5     
- Misses       5279     5284       +5     

see 4 files with indirect coverage changes

@elfenpiff elfenpiff merged commit 3b5567d into eclipse-iceoryx:main Jan 15, 2025
49 checks passed
@elfenpiff elfenpiff deleted the iox2-458-corrupted-service-cleanup branch January 15, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants