Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#566] Fix event based comm cxx example #567

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Dec 24, 2024

Inconsistent history requirements lead to a connection failure when the subscriber was created first.

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #566

orecham
orecham previously approved these changes Dec 24, 2024
@elfenpiff elfenpiff force-pushed the iox2-566-fix-event-based-comm-cxx-example branch from 7c046c9 to 97aff93 Compare December 24, 2024 10:30
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.31%. Comparing base (3526a25) to head (97aff93).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
+ Coverage   79.30%   79.31%   +0.01%     
==========================================
  Files         203      203              
  Lines       25230    25230              
==========================================
+ Hits        20008    20011       +3     
+ Misses       5222     5219       -3     

see 8 files with indirect coverage changes

@elfenpiff elfenpiff merged commit f4931fd into eclipse-iceoryx:main Dec 24, 2024
49 checks passed
@elfenpiff elfenpiff deleted the iox2-566-fix-event-based-comm-cxx-example branch December 24, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run event_based_communication on C++
2 participants