Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3] Enable Cirrus CI #561

Merged
merged 6 commits into from
Dec 20, 2024

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Dec 20, 2024

Notes for Reviewer

This PR re-enables the Cirrus CI and introduces the same handling for draft PRs like the github CI. Unfortunately, a dummy commit is required to trigger the Cirrus CI after the PR is marked ready for review.

Additionally, a the 'hashbrown' dependency was updated to fix a security vulnerability and 'cbindgen' was updated to get rid of the unmaintained 'atty' dependency.

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Relates to #3

@elBoberido elBoberido force-pushed the iox2-3-enable-cirrus-ci branch 2 times, most recently from cc88e43 to f0fcdf7 Compare December 20, 2024 18:30
@elBoberido elBoberido force-pushed the iox2-3-enable-cirrus-ci branch from f0fcdf7 to 5324cd1 Compare December 20, 2024 18:32
@elBoberido elBoberido force-pushed the iox2-3-enable-cirrus-ci branch 3 times, most recently from 01bf587 to 0face26 Compare December 20, 2024 21:01
@elBoberido elBoberido marked this pull request as ready for review December 20, 2024 21:01
@elBoberido elBoberido force-pushed the iox2-3-enable-cirrus-ci branch from 0face26 to 64ade9e Compare December 20, 2024 21:02
@elBoberido elBoberido self-assigned this Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.04%. Comparing base (750ac04) to head (244ab21).
Report is 16 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
+ Coverage   79.00%   79.04%   +0.03%     
==========================================
  Files         203      203              
  Lines       25307    25307              
==========================================
+ Hits        19995    20003       +8     
+ Misses       5312     5304       -8     

see 11 files with indirect coverage changes

@elBoberido elBoberido requested a review from elfenpiff December 20, 2024 21:23
@elBoberido elBoberido merged commit 83d797a into eclipse-iceoryx:main Dec 20, 2024
49 checks passed
@elBoberido elBoberido deleted the iox2-3-enable-cirrus-ci branch December 20, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants