[#555] health monitoring example cxx #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elBoberido
reviewed
Dec 20, 2024
elfenpiff
force-pushed
the
iox2-555-health-monitoring-example-cxx
branch
from
0e23095 to
97d1bf3
Compare
elBoberido
reviewed
Dec 20, 2024
CMakeLists.txt
Outdated
Comment on lines
113
to
122
| if(TREAT_WARNING_AS_ERROR) | ||
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Werror -Wall -Wextra -Wpedantic") | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror -Wall -Wextra -Wpedantic") | ||
| endif() |
There was a problem hiding this comment.
We need to handle this closer to iceoryx classic and enable those warnings by default. Not for this PR, though.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #558 +/- ##
=======================================
Coverage 79.00% 79.01%
=======================================
Files 203 203
Lines 25307 25307
=======================================
+ Hits 19995 19996 +1
+ Misses 5312 5311 -1 |
elfenpiff
force-pushed
the
iox2-555-health-monitoring-example-cxx
branch
4 times, most recently
from
ad393be to
9359090
Compare
elfenpiff
force-pushed
the
iox2-555-health-monitoring-example-cxx
branch
from
9359090 to
f8c372a
Compare
elBoberido
force-pushed
the
iox2-555-health-monitoring-example-cxx
branch
from
79e5b48 to
1f15827
Compare
elBoberido
force-pushed
the
iox2-555-health-monitoring-example-cxx
branch
from
1f15827 to
3d79678
Compare
…RROR; fix clang warnings
elfenpiff
force-pushed
the
iox2-555-health-monitoring-example-cxx
branch
from
32f34cd to
b79b0e3
Compare
elBoberido
previously approved these changes
Dec 20, 2024
elBoberido
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
Pre-Review Checklist for the PR Author
Convert to draft)SPDX-License-Identifier: Apache-2.0 OR MITiox2-123-introduce-posix-ipc-example)[#123] Add posix ipc example)task-list-completed)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #555