-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#264] cxx bindings for attributes #549
[#264] cxx bindings for attributes #549
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
==========================================
- Coverage 79.11% 79.07% -0.04%
==========================================
Files 203 203
Lines 25132 25146 +14
==========================================
+ Hits 19882 19885 +3
- Misses 5250 5261 +11
|
…::get into AttributeSet::get_key_values
568053f
to
ce1a959
Compare
|
||
/// Returns a [`AttributeView`] at a specific index. The number of indices is returned via | ||
/// [`AttributeSetView::len()`]. | ||
auto at(uint64_t index) const -> AttributeView; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Food for thought. For certification we might need to return an Optional<AttributeView>
to not have to terminate for out of bounds access.
But we need to review the whole API for this scenarios, so I think it's fine to stay as is for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or we work with begin()
and end()
and iterators or for_each
and for
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that's a different use case. If someone really wants to access element at index N, then it only works by checking the size before using at
... but that's a different philosophical question
…ndles with nullptr
c80fa01
to
5fa47fd
Compare
f79fcee
to
16398a8
Compare
16398a8
to
9ede743
Compare
9ede743
to
ce40c02
Compare
Adds the c/c++ binding for attributes and integrates them into the service builder.
Notes for Reviewer
Pre-Review Checklist for the PR Author
Convert to draft
)SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Relates to #264