Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#48] Adding audit scripts #49

Merged
merged 5 commits into from
Jan 5, 2024
+7 −1
Merged

[#48] Adding audit scripts #49

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
812efd2
[#48] Adding audit scripts
hydroid7 Dec 16, 2023
a5bb5cb
[#48] moving installation of cargo component to the dockerfiles.
hydroid7 Dec 19, 2023
55fee22
[#48] adds note about audit to the release
hydroid7 Dec 19, 2023
43fda38
[#48] Fix release notes.
hydroid7 Dec 26, 2023
077cbf0
Merge branch 'main' into iox-2-48-cargo-audit-ci
elfenpiff Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .cirrus.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ only_if: $CIRRUS_BRANCH == 'main' || ($CIRRUS_PR != '' && $CIRRUS_BASE_BRANCH ==
preflight_check_task:
<<: *IOX2_CONTAINER_UBUNTU_22_04_X64
set_toolchain_script: rustup default stable
fingerprint_script:
- cargo audit
# TODO iox2-#8: add more preflight-checks here
<<: *IOX2_CARGO_FMT_AND_CLIPPY
<<: *IOX2_COMMON_BUILD_DEBUG # only build without tests to not slow down other tasks due to failures in flaky tests
Expand Down
2 changes: 1 addition & 1 deletion doc/release-notes/iceoryx2-unreleased.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

### Workflow

* Example [#1](https://github.com/larry-robotics/iceoryx2/issues/1)
* add `cargo audit` for security vulnerability checking in dependencies [#49](https://github.com/eclipse-iceoryx/iceoryx2/issues/49)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* add `cargo audit` for security vulnerability checking in dependencies [#49](https://github.com/eclipse-iceoryx/iceoryx2/issues/49)
* add `cargo audit` for security vulnerability checking in dependencies [#48](https://github.com/eclipse-iceoryx/iceoryx2/issues/48)

Please always link to the actual issue instead of the PR :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hydroid7 whoopsie my mistake I mixed up the PR number and the issue number


### New API features

Expand Down
2 changes: 2 additions & 0 deletions internal/docker/archlinux-base-devel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ RUN echo "#### Installing dependencies" \
rustfmt \
&& echo "#### Installing cargo-nextest" \
&& cargo install cargo-nextest --locked \
&& echo "#### Installing cargo-audit" \
&& cargo install cargo-audit --locked \
&& echo "#### Creating users and groups required for tests" \
&& useradd testuser1 \
&& useradd testuser2 \
Expand Down
2 changes: 2 additions & 0 deletions internal/docker/ubuntu-22.04
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ RUN echo "#### Installing dependencies" \
rustfmt \
&& echo "#### Installing cargo-nextest" \
&& cargo install cargo-nextest --locked \
&& echo "#### Installing cargo-audit" \
&& cargo install cargo-audit --locked \
&& echo "Installing grcov" \
&& cargo install grcov \
&& echo "#### Creating users and groups required for tests" \
Expand Down