[#116] Fix race in shm create or open #124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
Fixes race in
posix::SharedMemory
.Solution: If create fails, try to reopen it.
Removes: retrieve buffer full check from zero copy sender. The sender does not have enough information available to determine if the buffer is really insufficient. It needs to know how many samples the subscriber has currently borrowed - an information only the receiver has.
Introduce memory sync in zero copy connection open procedure. When a zero copy connection is opened and the creation is still in progress, the opener will check the
init_state
until it is initialized. If it is signaling that the initialization is done, it will consume the contents - without memory sync. Addingacquire
/release
to sync the initialized memory with the other process.Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Relates to #116