-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#100] pub sub without lifetime arg #114
Merged
elfenpiff
merged 12 commits into
eclipse-iceoryx:main
from
elfenpiff:iox2-100-pub-sub-without-lifetime-arg
Feb 20, 2024
Merged
[#100] pub sub without lifetime arg #114
elfenpiff
merged 12 commits into
eclipse-iceoryx:main
from
elfenpiff:iox2-100-pub-sub-without-lifetime-arg
Feb 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
- Coverage 77.38% 77.37% -0.02%
==========================================
Files 181 177 -4
Lines 19599 19620 +21
==========================================
+ Hits 15166 15180 +14
- Misses 4433 4440 +7
|
elfenpiff
changed the title
[#100] pub sub without lifetime arg
[DO NOT REVIEW] [#100] pub sub without lifetime arg
Feb 10, 2024
elfenpiff
force-pushed
the
iox2-100-pub-sub-without-lifetime-arg
branch
from
February 11, 2024 09:10
77a51a3
to
00f86e4
Compare
elfenpiff
changed the title
[DO NOT REVIEW] [#100] pub sub without lifetime arg
[DO NOT REVIEW, based on PR #99] [#100] pub sub without lifetime arg
Feb 11, 2024
elfenpiff
force-pushed
the
iox2-100-pub-sub-without-lifetime-arg
branch
3 times, most recently
from
February 17, 2024 17:11
17321ea
to
91f1424
Compare
elfenpiff
changed the title
[DO NOT REVIEW, based on PR #99] [#100] pub sub without lifetime arg
[#100] pub sub without lifetime arg
Feb 17, 2024
elBoberido
reviewed
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. You have to incorporate the last bugfix with a rebase.
elfenpiff
force-pushed
the
iox2-100-pub-sub-without-lifetime-arg
branch
from
February 19, 2024 06:14
91f1424
to
65913ef
Compare
elBoberido
previously approved these changes
Feb 19, 2024
…rs; remove traits Subscribe and Payload
elfenpiff
force-pushed
the
iox2-100-pub-sub-without-lifetime-arg
branch
from
February 20, 2024 06:59
65913ef
to
bb0110e
Compare
elBoberido
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Relates to #100