Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#100] pub sub without lifetime arg #114

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Feb 10, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #100

@elfenpiff elfenpiff requested a review from elBoberido February 10, 2024 18:26
@elfenpiff elfenpiff self-assigned this Feb 10, 2024
@elfenpiff elfenpiff removed the request for review from elBoberido February 10, 2024 18:33
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 86 lines in your changes are missing coverage. Please review.

Comparison is base (80db0c4) 77.38% compared to head (637e681) 77.37%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   77.38%   77.37%   -0.02%     
==========================================
  Files         181      177       -4     
  Lines       19599    19620      +21     
==========================================
+ Hits        15166    15180      +14     
- Misses       4433     4440       +7     
Files Coverage Δ
iceoryx2/src/port/mod.rs 0.00% <ø> (ø)
iceoryx2/src/port/update_connections.rs 0.00% <ø> (ø)
iceoryx2/src/service/port_factory/listener.rs 60.00% <ø> (ø)
iceoryx2/src/service/port_factory/notifier.rs 87.50% <ø> (ø)
...ryx2/src/service/port_factory/publish_subscribe.rs 89.65% <100.00%> (ø)
iceoryx2/src/sample_mut.rs 80.55% <80.00%> (-2.78%) ⬇️
iceoryx2/src/port/listener.rs 58.75% <25.00%> (-3.10%) ⬇️
iceoryx2/src/sample.rs 47.82% <46.15%> (-2.18%) ⬇️
iceoryx2/src/port/notifier.rs 81.06% <20.00%> (-5.23%) ⬇️
iceoryx2/src/port/subscriber.rs 83.45% <59.09%> (+6.38%) ⬆️
... and 3 more

... and 1 file with indirect coverage changes

@elfenpiff elfenpiff changed the title [#100] pub sub without lifetime arg [DO NOT REVIEW] [#100] pub sub without lifetime arg Feb 10, 2024
@elfenpiff elfenpiff force-pushed the iox2-100-pub-sub-without-lifetime-arg branch from 77a51a3 to 00f86e4 Compare February 11, 2024 09:10
@elfenpiff elfenpiff changed the title [DO NOT REVIEW] [#100] pub sub without lifetime arg [DO NOT REVIEW, based on PR #99] [#100] pub sub without lifetime arg Feb 11, 2024
@elfenpiff elfenpiff force-pushed the iox2-100-pub-sub-without-lifetime-arg branch 3 times, most recently from 17321ea to 91f1424 Compare February 17, 2024 17:11
@elfenpiff elfenpiff changed the title [DO NOT REVIEW, based on PR #99] [#100] pub sub without lifetime arg [#100] pub sub without lifetime arg Feb 17, 2024
@elfenpiff elfenpiff requested a review from elBoberido February 18, 2024 09:46
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You have to incorporate the last bugfix with a rebase.

@elfenpiff elfenpiff force-pushed the iox2-100-pub-sub-without-lifetime-arg branch from 91f1424 to 65913ef Compare February 19, 2024 06:14
@elfenpiff elfenpiff requested a review from elBoberido February 19, 2024 06:15
elBoberido
elBoberido previously approved these changes Feb 19, 2024
@elfenpiff elfenpiff merged commit b068742 into eclipse-iceoryx:main Feb 20, 2024
20 of 23 checks passed
@elfenpiff elfenpiff deleted the iox2-100-pub-sub-without-lifetime-arg branch February 20, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants