[#573] Fix clang-tidy and clippy warnings

iceoryx2-ffi/cxx/include/iox2/enum_translation.hpp

@@ -304,6 +304,8 @@ constexpr auto from<int, iox2::EventOpenOrCreateError>(const int value) noexcept
         return iox2::EventOpenOrCreateError::OpenIncompatibleMessagingPattern;
     case iox2_event_open_or_create_error_e_O_INCOMPATIBLE_ATTRIBUTES:
         return iox2::EventOpenOrCreateError::OpenIncompatibleAttributes;
+    case iox2_event_open_or_create_error_e_O_INCOMPATIBLE_DEADLINE:
+        return iox2::EventOpenOrCreateError::OpenIncompatibleDeadline;
     case iox2_event_open_or_create_error_e_O_INTERNAL_FAILURE:
         return iox2::EventOpenOrCreateError::OpenInternalFailure;
     case iox2_event_open_or_create_error_e_O_HANGS_IN_CREATION:

iceoryx2-ffi/cxx/include/iox2/service_builder_event_error.hpp

@@ -99,6 +99,8 @@ enum class EventOpenOrCreateError : uint8_t {
     /// a corrupted
     /// [`Service`]state.
     OpenServiceInCorruptedState,
+    /// The [`Service`]s deadline settings are not equal the the user given requirements.
+    OpenIncompatibleDeadline,
     /// The [`Service`] has the wrong messaging pattern.
     OpenIncompatibleMessagingPattern,
     /// The [`AttributeVerifier`] required attributes that the [`Service`] does

iceoryx2-ffi/cxx/src/config.cpp

@@ -266,8 +266,9 @@ auto Event::deadline() && -> iox::optional<iox::units::Duration> {
 void Event::set_deadline(iox::optional<iox::units::Duration> value) && {
     value
         .and_then([&](auto value) {
-            uint64_t seconds = value.toSeconds();
-            uint32_t nanoseconds = value.toNanoseconds() - (value.toSeconds() * iox::units::Duration::NANOSECS_PER_SEC);
+            const uint64_t seconds = value.toSeconds();
+            const uint32_t nanoseconds =
+                value.toNanoseconds() - (value.toSeconds() * iox::units::Duration::NANOSECS_PER_SEC);
             iox2_config_defaults_event_set_deadline(m_config, &seconds, &nanoseconds);
         })
         .or_else([&] { iox2_config_defaults_event_set_deadline(m_config, nullptr, nullptr); });

iceoryx2-ffi/ffi/src/api/listener.rs

@@ -370,12 +370,12 @@ pub unsafe extern "C" fn iox2_listener_deadline(
         iox2_service_type_e::LOCAL => listener.value.as_mut().local.deadline(),
     };
 
-    deadline.map(|v| {
-        *seconds = v.as_secs();
-        *nanoseconds = v.subsec_nanos();
-    });
-
-    deadline.is_some()
+    deadline
+        .map(|v| {
+            *seconds = v.as_secs();
+            *nanoseconds = v.subsec_nanos();
+        })
+        .is_some()
 }
 
 /// Blocks the listener until at least one event was received and then calls the callback for

iceoryx2-ffi/ffi/src/api/notifier.rs

@@ -221,12 +221,12 @@ pub unsafe extern "C" fn iox2_notifier_deadline(
         iox2_service_type_e::LOCAL => notifier.value.as_mut().local.deadline(),
     };
 
-    deadline.map(|v| {
-        *seconds = v.as_secs();
-        *nanoseconds = v.subsec_nanos();
-    });
-
-    deadline.is_some()
+    deadline
+        .map(|v| {
+            *seconds = v.as_secs();
+            *nanoseconds = v.subsec_nanos();
+        })
+        .is_some()
 }
 
 /// Notifies all [`iox2_listener_h`](crate::iox2_listener_h) connected to the service

iceoryx2/src/port/listener.rs

@@ -150,8 +150,6 @@ impl<Service: service::Service> Listener<Service> {
                              with ListenerCreateError::ResourceCreationFailed,
                              "{} since the underlying event concept \"{}\" could not be created.", msg, event_name);
 
-        service.__internal_state().static_config.event().deadline;
-
         let mut new_self = Self {
             service_state: service.__internal_state().clone(),
             dynamic_listener_handle: None,