Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iox #337 create periodic task #460

Merged
merged 16 commits into from
Dec 22, 2020
Merged

Iox #337 create periodic task #460

merged 16 commits into from
Dec 22, 2020

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Dec 21, 2020 •
edited
Loading

Pre-Review Checklist for the PR Author

  1. Branch follows the naming format (iox-#123-this-is-a-branch)
  2. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  3. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  4. Relevant issues are linked
  5. Add sensible notes for the reviewer
  6. All checks have passed
  7. Assign PR to reviewer

Notes for Reviewer

This PR creates a PeriodicTask class which can be used to, well, execute periodic tasks. It also replaces the current posix::Timer to send the keep alive message. Once the periodic::Timer is refactored, it could be used as base for PeridodicTask

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

Post-review Checklist for the Eclipse Committer

  1. All checkboxes in the PR checklist are checked or crossed out
  2. Merge

References

@budrus budrus self-requested a review December 21, 2020 17:44
budrus
budrus previously approved these changes Dec 21, 2020
View reviewed changes
mossmaurice
mossmaurice reviewed Dec 21, 2020
View reviewed changes
iceoryx_utils/include/iceoryx_utils/internal/concurrent/periodic_task.hpp
private:
T m_callable;
units::Duration m_interval;
/// @todo use a refactored posix::Timer object once available
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shankar-bosch FYI

iceoryx_utils/include/iceoryx_utils/internal/concurrent/periodic_task.inl
{
m_callable();

/// @todo use a refactored posix::Timer::wait method returning TIMER_TICK and TIMER_STOPPED once available
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shankar-bosch FYI

iceoryx_utils/test/moduletests/test_concurrent_periodic_task.cpp Outdated Show resolved Hide resolved
@elBoberido elBoberido force-pushed the iox-#337-create-PeriodicTask branch from 8cc57b0 to 4694bc4 Compare December 22, 2020 13:12
@elBoberido elBoberido force-pushed the iox-#337-create-PeriodicTask branch from 6d575fe to bfe1e20 Compare December 22, 2020 14:58
elBoberido
elBoberido commented Dec 22, 2020
View reviewed changes
iceoryx_utils/platform/mac/source/semaphore.cpp
Comment on lines +148 to +152
constexpr int ETIMEDOUT_PLUS_256 = ETIMEDOUT + 256;
if (errno == ETIMEDOUT_PLUS_256)
{
errno &= 0xFF;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elfenpiff do you know why this works

@dkroenke dkroenke self-requested a review December 22, 2020 15:29
dkroenke
dkroenke previously approved these changes Dec 22, 2020
View reviewed changes
@mossmaurice mossmaurice added the refactoring Refactor code without adding features label Dec 22, 2020
@dkroenke dkroenke self-requested a review December 22, 2020 15:37
dkroenke
dkroenke previously approved these changes Dec 22, 2020
View reviewed changes
mossmaurice
mossmaurice previously approved these changes Dec 22, 2020
View reviewed changes
@elBoberido elBoberido dismissed stale reviews from mossmaurice and dkroenke via 1d37360 December 22, 2020 16:10
@dkroenke dkroenke self-requested a review December 22, 2020 16:14
@elBoberido elBoberido merged commit 0186384 into eclipse-iceoryx:master Dec 22, 2020
@elBoberido elBoberido deleted the iox-#337-create-PeriodicTask branch December 22, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkroenke dkroenke dkroenke approved these changes

@mossmaurice mossmaurice mossmaurice approved these changes

@budrus budrus budrus left review comments

@elfenpiff elfenpiff Awaiting requested review from elfenpiff

Assignees
No one assigned
Labels
refactoring Refactor code without adding features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate posix timer
4 participants
@elBoberido @mossmaurice @dkroenke @budrus