-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#1295 Update component and layer diagram for upcoming release #1600
iox-#1295 Update component and layer diagram for upcoming release #1600
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1600 +/- ##
==========================================
- Coverage 78.20% 77.42% -0.79%
==========================================
Files 360 366 +6
Lines 13862 14167 +305
Branches 1942 1984 +42
==========================================
+ Hits 10841 10969 +128
- Misses 2418 2569 +151
- Partials 603 629 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first two commits can be squashed
@dkroenke Typically, I prefer to keep separate things in separate commits, so you can later e.g. revert them individually with |
Signed-off-by: Simon Hoinkis <[email protected]>
Signed-off-by: Simon Hoinkis <[email protected]>
Signed-off-by: Simon Hoinkis <[email protected]>
Signed-off-by: Dietrich Krönke <[email protected]>
b43df4b
to
824b102
Compare
Signed-off-by: Simon Hoinkis <[email protected]>
Signed-off-by: Simon Hoinkis <[email protected]>
b5f4cca
to
7ed1c22
Compare
ba22490
to
593eb85
Compare
…module and create 'ipc' on one Signed-off-by: Simon Hoinkis <[email protected]>
593eb85
to
aeb182f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think we can merge this. I think the grouping would not be much more different if we continue to discuss this for another week.
Disclaimer: Didn't look for typos 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I only think that we really have to rename Queues
into Buffer
. When this is done I will approve it.
But if you have a fancy alternative I am also open for another name.
…ructure Signed-off-by: Simon Hoinkis <[email protected]>
78397e7
to
d22354c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add stack and variant queue to the Buffer table.
Signed-off-by: Simon Hoinkis <[email protected]>
✔️ I didn't add |
Pre-Review Checklist for the PR Author
Changelog updated in the unreleased section including API breaking changesNo user API changediox-123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
v3.x
releaseChecklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References
v3.0
#1295 (partly)