Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#337 remove posix timer #1376

Conversation

FerdinandSpitzschnueffler
Copy link
Contributor

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler commented May 30, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
    • Each unit test case has a unique UUID
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Use std::chrono::steady_clock instead of PosixTimer

Signed-off-by: Marika Lehmann <[email protected]>
@FerdinandSpitzschnueffler FerdinandSpitzschnueffler added the refactoring Refactor code without adding features label May 30, 2022
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #1376 (93ab230) into master (0477dfa) will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1376      +/-   ##
==========================================
+ Coverage   78.71%   78.88%   +0.17%     
==========================================
  Files         376      374       -2     
  Lines       14777    14541     -236     
  Branches     2066     2028      -38     
==========================================
- Hits        11632    11471     -161     
+ Misses       2466     2411      -55     
+ Partials      679      659      -20     
Flag Coverage Δ
unittests 78.55% <ø> (+0.60%) ⬆️
unittests_timing 14.73% <ø> (-0.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_posh/source/runtime/posh_runtime_impl.cpp 65.43% <0.00%> (-1.49%) ⬇️

@elBoberido elBoberido mentioned this pull request May 30, 2022
19 tasks
@FerdinandSpitzschnueffler FerdinandSpitzschnueffler merged commit 6a31326 into eclipse-iceoryx:master May 31, 2022
@FerdinandSpitzschnueffler FerdinandSpitzschnueffler deleted the iox-#337-remove-posix-timer branch May 31, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code without adding features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants