Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#743 Update lock-free queue design #1205

Conversation

MatthiasKillat
Copy link
Contributor

@MatthiasKillat MatthiasKillat commented Mar 2, 2022

Signed-off-by: Matthias Killat [email protected]

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
    • Each unit test case has a unique UUID
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@MatthiasKillat MatthiasKillat self-assigned this Mar 2, 2022
@MatthiasKillat MatthiasKillat force-pushed the iox-#743-validate-lockfree-queue-design branch from 55a43d4 to 1bab060 Compare March 2, 2022 17:24
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #1205 (1a32a85) into master (3f1db77) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1205      +/-   ##
==========================================
- Coverage   79.06%   79.01%   -0.05%     
==========================================
  Files         370      370              
  Lines       14660    14660              
  Branches     2046     2046              
==========================================
- Hits        11591    11584       -7     
- Misses       2399     2406       +7     
  Partials      670      670              
Flag Coverage Δ
unittests 78.24% <ø> (-0.05%) ⬇️
unittests_timing 13.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_posh/source/roudi/port_manager.cpp 84.54% <0.00%> (-1.34%) ⬇️

doc/design/lockfree_queue.md Outdated Show resolved Hide resolved
doc/design/lockfree_queue.md Outdated Show resolved Hide resolved
doc/design/lockfree_queue.md Outdated Show resolved Hide resolved
doc/design/lockfree_queue.md Outdated Show resolved Hide resolved
@MatthiasKillat MatthiasKillat force-pushed the iox-#743-validate-lockfree-queue-design branch from 1bab060 to 1a32a85 Compare March 2, 2022 20:05
@MatthiasKillat MatthiasKillat merged commit b8bb7c3 into eclipse-iceoryx:master Mar 3, 2022
@MatthiasKillat MatthiasKillat deleted the iox-#743-validate-lockfree-queue-design branch March 3, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation and website for v2.0
3 participants