-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#743 improve contributing md #1180
Merged
FerdinandSpitzschnueffler
merged 4 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#743-improve-contributing-md
Mar 1, 2022
Merged
iox-#743 improve contributing md #1180
FerdinandSpitzschnueffler
merged 4 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#743-improve-contributing-md
Mar 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marika Lehmann <[email protected]>
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler
added
the
documentation
Improvements or additions to documentation
label
Mar 1, 2022
Codecov Report
@@ Coverage Diff @@
## master #1180 +/- ##
==========================================
+ Coverage 78.92% 78.94% +0.02%
==========================================
Files 367 367
Lines 14627 14627
Branches 2045 2045
==========================================
+ Hits 11544 11547 +3
+ Misses 2412 2411 -1
+ Partials 671 669 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mossmaurice
reviewed
Mar 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, few nitpicks
…point Signed-off-by: Marika Lehmann <[email protected]>
mossmaurice
previously approved these changes
Mar 1, 2022
mossmaurice
changed the title
Iox #743 improve contributing md
iox-#743 improve contributing md
Mar 1, 2022
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler
force-pushed
the
iox-#743-improve-contributing-md
branch
from
March 1, 2022 17:18
a99b9ae
to
212b749
Compare
FerdinandSpitzschnueffler
requested review from
MatthiasKillat and
mossmaurice
and removed request for
dkroenke
March 1, 2022 17:21
MatthiasKillat
approved these changes
Mar 1, 2022
mossmaurice
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
Checklist for the PR Reviewer
Code according to our coding style and naming conventionsUnit tests have been written for new behaviorEach unit test case has a unique UUIDPublic API changes are documented via doxygenPost-review Checklist for the PR Author
References