Add landing page #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elBoberido
requested review from
mossmaurice,
dkroenke,
budrus,
elfenpiff,
MatthiasKillat and
FerdinandSpitzschnueffler
elBoberido
force-pushed
the
add-landing-page
branch
from
ed3825e to
f6d71d3
Compare
elBoberido
commented
Apr 6, 2024
elBoberido
commented
Apr 6, 2024
elfenpiff
approved these changes
Apr 7, 2024
|
@elBoberido Could you please create an issue and also adapt the script in the iceoryx repository accordingly? Once we run this script for the next |
mossmaurice
reviewed
Apr 8, 2024
There was a problem hiding this comment.
@elBoberido Thanks for the PR! The landing page looks great 🚀 I have a few findings, let me know if you need any support with addressing those.
elBoberido
force-pushed
the
add-landing-page
branch
from
f6d71d3 to
a6b00d1
Compare
mossmaurice
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead to redirecting to
iceoryx.io/latest, there is now a landing page with links to iceoryx and iceoryx2. For this, quite some files (js, css, logos) where copied fromv2.0.5to the root folder.I also updated the eclipse logo with the recommendations for dark backgrounds.
This is how it looks like with the update
Update:
