Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#70 Fix clippy warnings #71

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Aug 22, 2023

Pre-Review Checklist for the PR Author

  1. Code follows the Rust coding style and is formatted with rustfmt
  2. Branch follows the naming format (iox-123-this-is-a-branch)
  3. Commits messages are according to this guideline
  4. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  5. Relevant issues are linked
  6. Add sensible notes for the reviewer
  7. All checks have passed (except task-list-completed)
  8. Assign PR to reviewer

Notes for Reviewer

This PR fixes all the clippy warnings.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added the maintenance cleanups, technical dept, etc. label Aug 22, 2023
@elBoberido elBoberido requested a review from elfenpiff August 22, 2023 16:31
@elBoberido elBoberido self-assigned this Aug 22, 2023
Base automatically changed from iox-64-use-raw-sample-for-sys-crate to master September 17, 2023 16:06
@elBoberido elBoberido force-pushed the iox-70-fix-all-clippy-warnings branch from 680efa4 to 55d6aee Compare September 17, 2023 16:08
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2023

Codecov Report

Attention: Patch coverage is 35.24590% with 79 lines in your changes missing coverage. Please review.

Project coverage is 49.83%. Comparing base (f7573d8) to head (55d6aee).

Files with missing lines Patch % Lines
iceoryx-sys/src/introspection/port.rs 0.00% 26 Missing ⚠️
iceoryx-sys/src/introspection/process.rs 0.00% 15 Missing ⚠️
iceoryx-sys/src/subscriber.rs 59.45% 15 Missing ⚠️
iceoryx-sys/src/introspection/memory.rs 0.00% 12 Missing ⚠️
iceoryx-sys/src/publisher.rs 57.69% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
- Coverage   50.77%   49.83%   -0.95%     
==========================================
  Files          20       20              
  Lines        1154     1202      +48     
==========================================
+ Hits          586      599      +13     
- Misses        568      603      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elBoberido elBoberido merged commit 2559c28 into master Sep 17, 2023
10 of 11 checks passed
@elBoberido elBoberido deleted the iox-70-fix-all-clippy-warnings branch September 17, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance cleanups, technical dept, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix all clippy warnings
2 participants