-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and integrate Zest 2.0 development branch into GEF #324
Conversation
As described in the Javadoc for `Widget#dispose`, overriding `dispose` does not suffice to detect disposed parents, but we need to listen to disposal events.
…f/org.eclipse.zest.git
A layout algorithm that implements layered drawing for directed acyclic graphs using the Sugiyama method.
implemented incorrectly https://bugs.eclipse.org/bugs/show_bug.cgi?id=358941 Added scrolling functionality to AbstractStructuredGraphViewer.reveal
been taken from the following repository: https://github.com/fsteeg/zest The history has been preserved and remains unmodified. Only the latest commit adapts any compilation errors. The major version of all Zest bundles has been increased to 2 to indicated downwards incompatibility.
A few side notes:
|
Alternatively, I could move the "old" Zest plugins to a separate folder, do a normal rebase and then merge them back... |
Still not sure what the best solution is here... As the diff indicates, this change primarily consists of additions so I'm tempted to just squash it into a single commit. |
I'm not sure if we shoul really upgrade Zest to the 2.x version. There are users of Zest 1.x out there. Also we have improvements on Zest 1 in our repo (e.g. from @sebHollersbacher or @BauePhil). I don't think we want to loose them or? Based on the discussion in the mailing list I was more thinking that we could take the backwards compatible stuff and migrate it back. But I guess this would be more work or? |
Urgh... this'll be a LOT of work. After closer inspection, just the Zest 2.0 Layouts bundle alone looks completely different, with half the classes missing. Just look at e.g. their and our LayoutAlgorithm interface. Completely different. I'm closing this request, because I simply don't have an immediate answer for this. |
I hoped there where less changes. But it is still nice to have your PR as reference so that we can cherry pick things that sound interesting. |
I thought about this a little bit more and I believe we can do a backport of the cloudio bundle. It also just occurred to me that the I want to create a separate PR to integrate those changes and then, as you suggested, we can always cherry-pick the remaining parts as needed. Doing it like this would lessen the work by quite a lot, if we decide to touch this topic again. |
Cloudio would definitely be cool. |
This change merges the latest of Zest 2.0 into GEF. The sources have been taken from the following repository:
https://github.com/fsteeg/zest
The history has been preserved and remains unmodified. Only the latest commit adapts any compilation errors.
The major version of all Zest bundles has been increased to 2 to indicated downwards incompatibility.