-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UpdateSitePublisher -addJREIU argument doesn't add current JVM #462
Conversation
...org.eclipse.equinox.p2.publisher/src/org/eclipse/equinox/p2/publisher/actions/JREAction.java
Show resolved
Hide resolved
Build fails with |
Please add https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/master/.mvn/jvm.config to this repository as well, it should help with that OOM errors as currently only 1GB of 4G is used by default. |
We surely won't have that workaround be forever, is there a ticket for that so I can link the PR against? |
1a782bb
to
8cd02b9
Compare
Don't hard code "default" JRE version if we "guess one" and create some profile based on current JRE packages. Just read & use the version from the running JRE. Fixes eclipse-equinox#461
8cd02b9
to
b5f1716
Compare
If you mean we should stop development once we hit 1gb of memory demands then no there is no such ticket, beside that we don't get an refund if we only use 1/4 of available memory. |
I'm only asking for the root issue here, that requires now this workaround. |
I have recently analyzed the build and didn't find any unusual memory consumption, so the root cause seem that we are use more features, doing more checks and so on takes more memory so we hit a limit. As long as we are not really hitting the limit (e.g. need more and more and finally getting killed) I won't analyze further. So if 2g works for the next 20years its a bit of waste of dev resources otherwise. If you are interested, you can run the build local with -Xmx=1g (the current default) and let you produce a heapdump and look for possible optimizations in platform/jdt(I already made some) or tycho/maven (e.g MNG-7592. |
Don't hard code "default" JRE version if we "guess one" and create some profile based on current JRE packages.
Just read & use the version from the running JRE.
Fixes #461